GitLab

This is likely still not complete, but with this at least most of
Itinerary's metadata translations are accepted during upload to the
Google Play store (the remaining ones are rejected for different reasons).
F-Droid seems considerably less picky about this, and works with either
form.

The symbol export/visibility attribute is not standardized so far and
needs to be set by language extension attribute declaration at least
with clang & MSVC, who both support that when it appears before the
standard attribute declaration.

NO_CHANGELOG

NO_CHANGELOG

NO_CHANGELOG

BUG: 436155

NO_CHANGELOG

We want to know here if the standard attribute is available

NO_CHANGELOG

NO_CHANGELOG

CMake >= 3.0 supports bracket comments, and the reStructuredText
integration code in sphinx/ext/ecm.py already supports extracting
the docs from a bracket comment instead.
Editing documentation without leading line comment markers is more simple,
e,g. when reflowing text over lines.

With ECM meanwhile requiring CMake 3.5 now it is possible to switch
(and thus follow also the approach used by cmake itself).

NO_CHANGELOG

If we tell the compiler to link the runtime statically and then explicitly link
the dynamic runtime and prohibit the static we continue to produce dynamic
builds...

That's the case when using KDE_L10N_AUTO_TRANSLATIONS, and the code handles
this case above when looking for the right po location already, but that
result was accidentally discarded here.

We need this to pass the --release option for binary factory release
builds.

An alternative approach would be to set that here automatically depending
on the CMake build type. Since that however ends up producing unsigned and
thus not immediately usable APKs (or would need a whole set of extra
arguments for proper signing) I'm not sure whether that's most convenient
for local use.

To prevent accidental use of the C++-side hex number-style version variants
on the cmake side where human-readable style is used instead (which can
happen due to the similar names of the cmake variables/arguments
and C++ macros which screws up developers' brain) we better do some
proper input checks also on the arguments EXCLUDE_DEPRECATED_BEFORE_AND_AT
and DEPRECATED_BASE_VERSION

The code argument has been deprecated in favor of public-code and
private-code options.

In general, it is highly advised to use the private-code option, but we
cannot do it because it will break the ABI.

This is a slightly modernized version of Pino's original implementation
found in KF5 and Plasma.

This matches most of the existing code in KDE; also note that Qt has the
same setting (also stating in a comment in their _clang-format that this
matching their existing code).

To prevent cmake errors with exiting usages it is checked if the target already exists.

We have identical copies of this in kinit, kwin, ksysguard and
powerdevil. This makes it a natural candidate for inclusion in ECM.

When the qt install prefix and the qt host data path are the same,
CMake's RELATIVE_PATH file path function will return the empty string.
This made us accidentally set ECM_MKSPECS_INSTALL_DIR to /mkspecs/modules.
Fix this by explicitly checking for the empty string. Once we can depend on
CMake 3.20, we can use CMake's builtin function for joining paths instead.

When building multiple KDE projects, installing them to "$DESTDIR"
and having cmake look for kde dependencies in "$DESTDIR" using
"CMAKE_PREFIX_PATH=$DESTDIR/usr", we currently get failures when
calling find_package() on projects that use KDE_INSTALL_QTPLUGINDIR,
KDE_INSTALL_QTQMLDIR and KDE_INSTALL_QTQUICKIMPORTSDIR because these
are defined as absolute paths when KDE_INSTALL_USE_QT_SYS_PATHS is
enabled.

This commit defines these paths relative to qmake's QT_INSTALL_PREFIX
property instead when KDE is install to the same prefix as Qt. This
fixes DESTDIR installations because with relative paths, CMake will
search for these paths in "$DESTDIR" as well as "/".

We limit this change to the scenario where the Qt and CMake install
prefixes are the same because always doing this would break backwards
compatibility as qml and plugins would be installed into CMAKE_INSTALL_PREFIX
instead of QT_INSTALL_PREFIX after this change.

The --sort=name option was only added in version 1.28
which isn't available in Centos 7 yet e.g.

This is no longer needed now that the metadata happens as part of the
build process rather than afterwards on the signing system. This allows
us to simplify the code here a bit.

GIT_SILENT

It was reported that in case of containerized setups where the
source and build are in different containers the pre-commit
script would reference a file which is another container and
is consequently not found.

To avoid this the script is copied in the source dir and a relative path is defined.