1. 01 Jul, 2020 1 commit
  2. 30 Jun, 2020 1 commit
  3. 24 Jun, 2020 2 commits
  4. 23 Jun, 2020 1 commit
  5. 22 Jun, 2020 1 commit
    • Volker Krause's avatar
      Deal with Qt's CMake code modifying CMAKE_SHARED_LIBRARY_SUFFIX · 13a1161d
      Volker Krause authored
      Qt adds the Android ABI to the suffix there unconditionally, without also
      adjusting CMAKE_FIND_LIBRARY_SUFFIXES accordingly, breaking find_library()
      for things built that way. Unfortunately we can't just set this in our
      toolchain file, as CMAKE_FIND_LIBRARY_SUFFIXES is overwritten by CMake
      after evaluating the toolchain file. So we need to use the variable_watch
      hack for this here, thanks to Aleix for the idea.
      
      With this, find_library() works for both suffixed and un-suffixed libraries
      again, such as Poppler built with or without Qt support.
      13a1161d
  6. 17 Jun, 2020 1 commit
  7. 14 Jun, 2020 1 commit
  8. 13 Jun, 2020 1 commit
  9. 19 May, 2020 2 commits
  10. 13 May, 2020 1 commit
    • Friedrich W. H. Kossebau's avatar
      ECMGenerateExportHeader: add generation of *_DEPRECATED_VERSION_BELATED() · cc8bccad
      Friedrich W. H. Kossebau authored
      Summary:
      Now and then tagging some API as deprecated for the compiler is forgotten.
      Doing this retractivitly in newer versions but using the official version
      might break build setups configured to only show warnings up to a certain
      version and otherwise fail a build, using -Werror=deprecated-declarations.
      
      To allow retroactive tagging of API for compiler warnings, and showing the
      official version in the warniung message, while reacting only to warning
      controls for the current version where the tag is added, avoids any such
      annoying experiences, without wrong version info at the same time.
      
      Reviewers: #frameworks, #build_system, dfaure
      
      Reviewed By: dfaure
      
      Subscribers: kde-frameworks-devel, kde-buildsystem
      
      Tags: #frameworks, #build_system
      
      Differential Revision: https://phabricator.kde.org/D29573
      cc8bccad
  11. 11 May, 2020 1 commit
    • Nicolas Fella's avatar
      [android] Allow specifying APK install location · a70e9a01
      Nicolas Fella authored
      Summary:
      This allows `make create-apk` to directly write the APK to /output instead of the cp-with-prefix step in /opt/helpers/create-apk. It's also useful for manual development builds where one would need to copy it to some output location manually or for CI setups that expect the output in a certain location.
      
      If ANDROID_APK_INSTALL_DIR is not set the current behaviour is kept.
      
      Reviewers: #frameworks, #android, apol, vkrause
      
      Reviewed By: #android, apol
      
      Subscribers: kde-frameworks-devel, kde-buildsystem
      
      Tags: #frameworks, #build_system
      
      Differential Revision: https://phabricator.kde.org/D29631
      a70e9a01
  12. 09 May, 2020 1 commit
  13. 08 May, 2020 2 commits
    • David Faure's avatar
      ECMGeneratePriFile: fix for ECM_MKSPECS_INSTALL_DIR being absolute · bac76085
      David Faure authored
      Test Plan: works as before for the case where it's relative.
      
      Reviewers: cgiboudeaux, vatra, kfunk, apol, vkrause
      
      Reviewed By: cgiboudeaux
      
      Subscribers: kde-frameworks-devel, kde-buildsystem
      
      Tags: #frameworks, #build_system
      
      Differential Revision: https://phabricator.kde.org/D29524
      bac76085
    • David Faure's avatar
      ECMGeneratePriFile: make the pri files relocatable · 856fc410
      David Faure authored
      Summary:
      Instead of generating
      QT.KArchive.includes = /full/path/include/KF5/KArchive
      make it
      QT.KArchive.includes = $$PWD/../../include/KF5/KArchive
      
      This makes the whole install prefix relocatable after the fact,
      the includes will be found based on where the .pri file ended up.
      
      This is especially useful for Conan support, says Bogdan.
      
      Test Plan: After make install in ECM, cd karchive/examples/helloworld && qmake && make
      
      Reviewers: vatra, kfunk, apol, vkrause
      
      Reviewed By: vkrause
      
      Subscribers: ablu, kossebau, kde-frameworks-devel, kde-buildsystem
      
      Tags: #frameworks, #build_system
      
      Differential Revision: https://phabricator.kde.org/D29274
      856fc410
  14. 04 May, 2020 1 commit
    • Xuetian Weng's avatar
      Suppress find_package_handle_standard_args package name mismatch warning. · 8d181637
      Xuetian Weng authored
      Summary:
      cmake introduced a new find_package mismatch check in 3.17, but also allows
      user to suppress the warning by setting a variable (Or parameter, but
      require new cmake 3.17). Same technique is also used with in cmake,
      e.g. FindGTK2.cmake.
      
      Test Plan: Test with FindXCB.cmake
      
      Reviewers: #frameworks, #build_system, apol
      
      Reviewed By: apol
      
      Subscribers: apol, kde-frameworks-devel, kde-buildsystem
      
      Tags: #frameworks, #build_system
      
      Differential Revision: https://phabricator.kde.org/D29396
      8d181637
  15. 28 Apr, 2020 1 commit
  16. 26 Apr, 2020 1 commit
  17. 22 Apr, 2020 1 commit
  18. 19 Apr, 2020 1 commit
  19. 18 Apr, 2020 1 commit
    • Aleix Pol Gonzalez's avatar
      Fix wayland scanner warnings · 3734a536
      Aleix Pol Gonzalez authored
      Summary: Tells cmake not to automoc certain files that don't need it, which would become a big fuss on the cmake output.
      
      Test Plan: No warnings
      
      Reviewers: #build_system, #kwin, #frameworks, davidedmundson
      
      Reviewed By: #kwin, davidedmundson
      
      Subscribers: kde-frameworks-devel, kde-buildsystem
      
      Tags: #frameworks, #build_system
      
      Differential Revision: https://phabricator.kde.org/D28900
      3734a536
  20. 11 Apr, 2020 1 commit
  21. 05 Apr, 2020 1 commit
    • David Faure's avatar
      ECM: attempt to fix KDEInstallDirsTest.relative_or_absolute on Windows · 907d46e0
      David Faure authored
      Summary:
      Not passing CMAKE_INSTALL_PREFIX is a weird thing to do. The test shows
      "Installing in ." and some values like KDE_INSTALL_FULL_EXECROOTDIR
      become "/" which is considered relative on Windows.
      
      The test that passes /usr to CMAKE_INSTALL_PREFIX actually passes on
      Windows. Pass /tmp to the other test, remove the test without prefix.
      
      Test Plan: Passes on Linux, not tested on Windows, CI will do that
      
      Reviewers: kossebau, apol, cgiboudeaux
      
      Reviewed By: apol
      
      Subscribers: kde-frameworks-devel, kde-buildsystem
      
      Tags: #frameworks, #build_system
      
      Differential Revision: https://phabricator.kde.org/D28409
      907d46e0
  22. 24 Mar, 2020 1 commit
  23. 12 Mar, 2020 1 commit
  24. 07 Mar, 2020 1 commit
  25. 06 Mar, 2020 1 commit
  26. 03 Mar, 2020 1 commit
    • Volker Krause's avatar
      Support NDK r20 and Qt 5.14 · c9ebd391
      Volker Krause authored
      Summary:
      This changes from using the toolchain file provided by CMake to using the
      one provided by the NDK, as even recent CMake can't build successfully
      with r20. However this is a rather invasive change, the interface and
      variable names differ.
      
      The Qt 5.14 changes are less risky, as most of this is parallel to the
      support for older versions.
      
      Test Plan: Local builds with 5.14/r20, 5.14/r18 work, the Docker SDK isn't tested yet, and there's some remaining issues with 5.13 and older NDKs I don't fully understand yet. The resulting apks with 5.14 install, and work for QQC2 content, but fail to start Kirigami apps.
      
      Reviewers: apol
      
      Reviewed By: apol
      
      Subscribers: flherne, apol, kde-frameworks-devel, kde-buildsystem
      
      Tags: #frameworks, #build_system
      
      Maniphest Tasks: T12520
      
      Differential Revision: https://phabricator.kde.org/D26749
      c9ebd391
  27. 26 Feb, 2020 1 commit
  28. 12 Feb, 2020 2 commits
  29. 11 Feb, 2020 1 commit
  30. 10 Feb, 2020 1 commit
    • Friedrich W. H. Kossebau's avatar
      Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category · 86041b6d
      Friedrich W. H. Kossebau authored
      Summary:
      Having to manually maintain a separate copy of all the data about qt logging
      categories in the categories files comes with the usual disadvantages.
      The new macro ecm_qt_install_logging_categories together with the additions
      of arguments DESCRIPTION & EXPORT to ecm_qt_declare_logging_category allows
      to have just one place with one copy of the data, and have the categories
      file automatically generated from that data, linked via the EXPORT id.
      
      For cases not using ecm_qt_declare_logging_category, but having categories
      manually defined in code, yet wanting to have info about those categories in
      the installed fiel, ecm_qt_export_logging_category allows to add those data
      to the system.
      
      Test Plan:
      Added unit tests work, porting of some repos created categories files whose
      diff against the manually created files were only the DO_NOT_EDIT header.
      
      Reviewers: #build_system, #frameworks, broulik, mlaurent
      
      Reviewed By: mlaurent
      
      Subscribers: kde-frameworks-devel, kde-buildsystem
      
      Tags: #frameworks, #build_system
      
      Differential Revision: https://phabricator.kde.org/D27150
      86041b6d
  31. 09 Feb, 2020 1 commit
  32. 08 Feb, 2020 1 commit
  33. 07 Feb, 2020 1 commit
    • Kevin Funk's avatar
      ECMGeneratePriFile: Fix static configurations · fafbc8ce
      Kevin Funk authored
      Summary:
      Populate module_config with staticlib. This is needed for Qt 5.12, as
      Makefiles contain the full path to the library instead of just the base
      name. QMake needs to be aware of the build type. This issue was found in
      KDStateMachineEditor's .pri files.
      
      Before this patch the linker tried to link against .so files even for
      static libraries.
      
      Note: Probably not very relevenat to KDE Frameworks (since it's all
      about shared libraries, but I'd like to keep the original
      ECMGeneratePriFile version up-to-date)
      
      Compare:
      
      ```
      % cat kdsme-qmake-test.pro
      QT += KDSMEDebugInterfaceSource
      
      !qtHaveModule(KDSMEDebugInterfaceSource): warning("Library not found")
      
      SOURCES += main.cpp
      
      % qmake --version
      QMake version 3.1
      Using Qt version 5.9.8 in /home/kfunk/devel/build/qt5.9/qtbase/lib
      % qmake .
      % make
      ...
      g++ -Wl,-rpath,/home/kfunk/devel/build/qt5.9/qtbase/lib ...  -L.../lib -lkdstatemachineeditor_debuginterfacesource ...
      
      % make clean
      
      % env-qt5.12
      % qmake --version
      QMake version 3.1
      Using Qt version 5.12.5 in /home/kfunk/devel/build/qt5.12/qtbase/lib
      
      % qmake .
      % make
      ...
      g++ -Wl,-rpath,/home/kfunk/devel/build/qt5.12/qtbase/lib ... .../lib/libkdstatemachineeditor_debuginterfacesource.a ...
      
      Reviewers: dfaure, winterz, vkrause, apol
      
      Reviewed By: apol
      
      Subscribers: kde-frameworks-devel, kde-buildsystem
      
      Tags: #frameworks, #build_system
      
      Differential Revision: https://phabricator.kde.org/D26394
      fafbc8ce
  34. 28 Jan, 2020 1 commit
    • Tomaz  Canabrava's avatar
      Add missing Import Env Variable · ee053174
      Tomaz Canabrava authored
      Summary:
      Without this, in Qt 5.14 I get an android-like QQC2 theme
      This used to work on Qt 5.13 so I assume that it's a regression
      
      Reviewers: mart
      
      Reviewed By: mart
      
      Subscribers: apol, davidedmundson, kde-frameworks-devel, kde-buildsystem
      
      Tags: #frameworks, #build_system
      
      Differential Revision: https://phabricator.kde.org/D26573
      ee053174
  35. 26 Jan, 2020 1 commit
  36. 23 Jan, 2020 1 commit