KArchive merge requests
https://invent.kde.org/frameworks/karchive/-/merge_requests
2023-12-16T17:50:57Z
https://invent.kde.org/frameworks/karchive/-/merge_requests/69
GIT_SILENT Port to new way of including CI templates
2023-12-16T17:50:57Z
Albert Astals Cid
GIT_SILENT Port to new way of including CI templates
https://invent.kde.org/frameworks/karchive/-/merge_requests/68
KBzip2Filter: improve error message in uncompress
2023-12-01T09:06:17Z
Méven Car
KBzip2Filter: improve error message in uncompress
Also add calls to bzDecompressEnd, after error as documentation recommends. ref https://sourceware.org/bzip2/manual/manual.html#bzDecompress
I noticed some errors in dolphin or plasmashell output `kf.archive: bzDecompress returned -5`
...
Also add calls to bzDecompressEnd, after error as documentation recommends. ref https://sourceware.org/bzip2/manual/manual.html#bzDecompress
I noticed some errors in dolphin or plasmashell output `kf.archive: bzDecompress returned -5`
This ought to be more informative.
https://invent.kde.org/frameworks/karchive/-/merge_requests/60
Make bzip, lzma, zstd soft-mandatory
2023-11-28T02:40:50Z
Albert Astals Cid
Make bzip, lzma, zstd soft-mandatory
They are required by default and there's an option() to disable them
They are required by default and there's an option() to disable them
https://invent.kde.org/frameworks/karchive/-/merge_requests/66
KArchive::writeFile(...): use QByteArrayView for data arg
2023-11-23T23:34:32Z
Friedrich W. H. Kossebau
KArchive::writeFile(...): use QByteArrayView for data arg
Following the ideas of !65 to allow views. Suddenly all `archive.writeFile(filename, "data");` will even no longer be deep copies into a QByteArray first :)
Following the ideas of !65 to allow views. Suddenly all `archive.writeFile(filename, "data");` will even no longer be deep copies into a QByteArray first :)
https://invent.kde.org/frameworks/karchive/-/merge_requests/65
Add KArchive::writeData(QByteArrayView) overload, make virtual a do*() one
2023-11-23T23:32:28Z
Friedrich W. H. Kossebau
Add KArchive::writeData(QByteArrayView) overload, make virtual a do*() one
Using KArchive::doWriteData() for the virtual method makes the pattern
consistent with prepareWriting & finishWriting.
It also avoids the need to add "using KArchive::writeData" to subclasses
reimplementing the virtual method, as now nee...
Using KArchive::doWriteData() for the virtual method makes the pattern
consistent with prepareWriting & finishWriting.
It also avoids the need to add "using KArchive::writeData" to subclasses
reimplementing the virtual method, as now needed with the overload.
~~Open question:~~
~~currently the type used for `size` with the `writeData()` method is `qint64`, matching what is also seen with QIODevice. Does this make sense here for writing chunks of data? Or would we just remove reduce this to `qsietype`, given chunks of working memory might not be larger than what qsizetype (& malloc) can provide, or is there a chance?~~ Answered.
https://invent.kde.org/frameworks/karchive/-/merge_requests/64
Fix broken bzip2 with new shared-mime-info
2023-11-20T20:48:39Z
Albert Astals Cid
Fix broken bzip2 with new shared-mime-info
https://invent.kde.org/frameworks/karchive/-/merge_requests/67
Bump Qt deprecation level to 6.5
2023-11-17T15:26:34Z
Volker Krause
vkrause@kde.org
Bump Qt deprecation level to 6.5
GIT_SILENT
GIT_SILENT
https://invent.kde.org/frameworks/karchive/-/merge_requests/63
karchivetest: QVERIFY KArchiveFile* before dereferencing it
2023-11-07T22:05:34Z
Igor Kushnir
karchivetest: QVERIFY KArchiveFile* before dereferencing it
This replaces a test crash with a test failure.
This replaces a test crash with a test failure.
https://invent.kde.org/frameworks/karchive/-/merge_requests/62
There's no QVector anymore, QList is the QVector in Qt6
2023-10-20T08:04:57Z
Laurent Montel
There's no QVector anymore, QList is the QVector in Qt6
Laurent Montel
Laurent Montel
https://invent.kde.org/frameworks/karchive/-/merge_requests/61
Proofreading
2023-10-05T17:49:07Z
Marius Pa
Proofreading
https://invent.kde.org/frameworks/karchive/-/merge_requests/58
Support reading file sizes from ZIP64 extended fields
2023-08-03T15:40:40Z
Volker Krause
vkrause@kde.org
Support reading file sizes from ZIP64 extended fields
While Qt 5 would possibly struggle with things needing that extension, I
have encountered one file in the wild (an Apple Wallet pass) that uses
this extension despite only being a few kB in size.
(cherry picked from commit 6581272326b2...
While Qt 5 would possibly struggle with things needing that extension, I
have encountered one file in the wild (an Apple Wallet pass) that uses
this extension despite only being a few kB in size.
(cherry picked from commit 6581272326b27a3debd3b9c257d5e304ecda31fb)
https://invent.kde.org/frameworks/karchive/-/merge_requests/57
Support reading file sizes from ZIP64 extended fields
2023-08-02T22:29:41Z
Volker Krause
vkrause@kde.org
Support reading file sizes from ZIP64 extended fields
While Qt 5 would possibly struggle with things needing that extension, I
have encountered one file in the wild (an Apple Wallet pass) that uses
this extension despite only being a few kB in size.
While Qt 5 would possibly struggle with things needing that extension, I
have encountered one file in the wild (an Apple Wallet pass) that uses
this extension despite only being a few kB in size.
https://invent.kde.org/frameworks/karchive/-/merge_requests/56
Add explicit moc includes to sources for moc-covered headers
2023-06-29T20:21:38Z
Friedrich W. H. Kossebau
Add explicit moc includes to sources for moc-covered headers
* speeds up incremental builds as changes to a header will not always
need the full mocs_compilation.cpp for all the target's headers rebuild,
while having a moc file sourced into a source file only adds minor
extra costs, due to s...
* speeds up incremental builds as changes to a header will not always
need the full mocs_compilation.cpp for all the target's headers rebuild,
while having a moc file sourced into a source file only adds minor
extra costs, due to small own code and the used headers usually
already covered by the source file, being for the same class/struct
* seems to not slow down clean builds, due to empty mocs_compilation.cpp
resulting in those quickly processed, while the minor extra cost of the
sourced moc files does not outweigh that in summary.
Measured times actually improved by some percent points.
(ideally CMake would just skip empty mocs_compilation.cpp & its object
file one day)
* enables compiler to see all methods of a class in same compilation unit
to do some sanity checks
* potentially more inlining in general, due to more in the compilation unit
* allows to keep using more forward declarations in the header, as with the
moc code being sourced into the cpp file there definitions can be ensured
and often are already for the needs of the normal class methods
moc includes generated with script from sdk/kde-dev-scripts!24 + some manual fine-tuning of newlines.
Checked completeness by this running in the toplevel build dir giving `0`:
`find . -name mocs_compilation.cpp -exec cat {} \; | grep "#include" | wc -l`
https://invent.kde.org/frameworks/karchive/-/merge_requests/54
karchiveentry.h: add missing KArchive forward declaration
2023-04-02T13:35:36Z
Friedrich W. H. Kossebau
karchiveentry.h: add missing KArchive forward declaration
Found when accidentally including `<KArchiveEntry>` as first header.
Found when accidentally including `<KArchiveEntry>` as first header.
https://invent.kde.org/frameworks/karchive/-/merge_requests/53
Use more explicit constructors
2023-03-21T20:57:03Z
Friedrich W. H. Kossebau
Use more explicit constructors
@aacid
@aacid
https://invent.kde.org/frameworks/karchive/-/merge_requests/52
Fix the translation template number (5->6)
2023-03-13T22:54:29Z
Luigi Toscano
Fix the translation template number (5->6)
KF5 and KF6 must be co-installable, so change the major version
number integrated into the translation template name.
KF5 and KF6 must be co-installable, so change the major version
number integrated into the translation template name.
https://invent.kde.org/frameworks/karchive/-/merge_requests/51
Fix warning when building without Zstd support
2023-02-08T22:53:24Z
Claudio Cambra
Fix warning when building without Zstd support
This MR fixes a build warning when building KArchive without Zstd support
```
/Users/claucambra/Downloads/karchive/src/kcompressiondevice.cpp:162:13: warning: enumeration value 'Zstd' not handled in switch [-Wswitch]
switch (type) {...
This MR fixes a build warning when building KArchive without Zstd support
```
/Users/claucambra/Downloads/karchive/src/kcompressiondevice.cpp:162:13: warning: enumeration value 'Zstd' not handled in switch [-Wswitch]
switch (type) {
^~~~
/Users/claucambra/Downloads/karchive/src/kcompressiondevice.cpp:162:13: note: add missing switch cases
switch (type) {
^
1 warning generated.
```
Claudio Cambra
Claudio Cambra
https://invent.kde.org/frameworks/karchive/-/merge_requests/50
Remove Qt 5 support
2023-01-22T07:46:35Z
Volker Krause
vkrause@kde.org
Remove Qt 5 support
https://invent.kde.org/frameworks/karchive/-/merge_requests/49
Remove all deprecated API
2023-01-21T16:29:16Z
Nicolas Fella
Remove all deprecated API
https://invent.kde.org/frameworks/karchive/-/merge_requests/48
Rename CMake targets/config/libraries for KF6
2023-01-20T16:05:28Z
Nicolas Fella
Rename CMake targets/config/libraries for KF6