GitLab

This reverts commit c5d7bc89.

For some reason, CI had trouble to compile toString(calendar),
making toString(KCalendarCore::MemoryCalendar::Ptr&) and
toString(const KCalendarCore::Incidence::Ptr&) ambiguous.
Add the optional argument to the first call so the ambiguity
is raised.

MemoryCalendar::rawTodos() can already use open bounds, but
rawEvents() cannot. This patch is fixing this and is adding
a non-regression test for events.

License change confirmed by relicensecheck.pl and manual review
of copyright holders in license header.

When setting custom a property with CustomProperties::setNonKDECustomProperty,
save properties starting with X-KDE-VOLATILE- into the mVolatileProperties
member. This is symetrical with removeNonKDECustomProperty().

- test that the transitions match the tzdump output
- there are 2 transitions in the relevant timeframe

See https://community.kde.org/Frameworks/Frameworks_Logging_Policy

- The "short form" timezone "GMT" does not always exist on FreeBSD. Use short form "UTC" instead.
- While here, add a little test that the named timezone is valid.
- Make tests a little more explicit as to what they're testing.

The value of the `start` parameter does not affect the all-day setting.

GIT_SILENT

GIT_SILENT

GIT_SILENT

QSaveFile::write() doesn't return an error if the write fails because
the disk is full, at least on Linux when writing to an unnamed
temporary file. This fix works around this by checking that the
buffered write can be flushed to disk and if not, returning an error.

BUG: 370708

`Todo::iconName()` compares a "recurrenceId" to the due date of the current
occurrence of the todo to decide whether the specified occurrence has been
completed.
 * To-dos do not have to have a due date.  In that case the comparison
   fails, and `"view-calendar-tasks"` is always returned.
 * RFC 2445/RFC 5545 say that a recurrence ID is the start date of an
   occurrence, and KOrganizer's Agenda view passes start dates to
  `iconName()`.  In that case `iconName()` incorrectly returns
  `"task-complete"` for the first occurrence of a never-completed to-do.

Comparing the recurrence ID to the start date of the current occurrence
fixes the problems.

KCalendarCore uses Todo::Private::mDtRecurrence to hold the start date
and time of the next uncompleted occurrance of a recurring Todo, and
deserializes it from the X-KDE-LIBKCAL-DTRECURRENCE property of iCalendar
files.  However, ICalFormatImpl::writeTodo() serializes dtDue() into that
property, not dtStart().

When KOrganizer creates a new recurring to-do, it serializes the to-do,
then deserializes it to populate the To-Do List view, so the view shows
an incorrect start date (and an incorrect due date, which is calculated
from the start date).

BUG: 345498
BUG: 345565

Also, edits the comments on getNextDayTime()'s declaration to make it
plain that the the start dates are used, as opposed to the due dates.

if iCalendar loading fails in ICalFormat::load() set exception
Then look for that exception in FileStorage::load(). If set,
we know to try vCalendar loading.

Differential Revision: https://phabricator.kde.org/D28361