GitLab

These functions allow an application to save and restore the positions
of its windows. Positions are stored on a per-screen-arrangement basis.

For example with a single screen connected, the config file would have
entries like this in it:

eDP-1 XPosition=140
eDP-1 YPosition=340

When a second screen is connected, the following gets saved:

eDP-1 HDMI-1 XPosition=3878
eDP-1 HDMI-1 YPosition=29

This ensures that each separate screen arrangement can have its own
saved window position, which is handy for the use case where you have a
laptop that you plug into an external screen some of the time. It also
allows the position to get restored to the correct screen when there are
multiple screens.

This is a necessary first step to getting KDE apps to save their window
positions on X11 The next step would be calling the new functions from
KXMLGui and Kirigami apps, and then porting all apps that manually invoke
KWindowConfig::saveWindowSize() and KWindowConfig::restoreWindowSize()
to also invoke KWindowConfig::saveWindowPosition() and
KWindowConfig::restoreWindowPosition() in the same places.

The functions only work on X11 or other non-Wayland platforms. On
Wayland, the compositor has sole dominion over window positioning so a
compositor-specific solution much be adopted instead, such as
https://bugs.kde.org/show_bug.cgi?id=15329.

CCBUG: 415150

When running unit tests, usually QStandardPaths TestMode is enabled so as
not to mess up the config files in the home dir of the dev running the unit
tests; sGlobalFileName, a global static, was defined only once, which meant
that if KSharedConfig::openConfig() is called before the unit test has had
a chance to call QStandardPaths::setTestModeEnabled(true), then sGlobalFileName
will go on referring to the wrong kdeglobals file (as can be seen in
dfaure's debugging of the issue at [1]). Change the code so as to
detect QStandardPaths TestMode status and change sGlobalFileName as needed.

All unit tests still pass.

[1] kio!77 (comment 74124)

While the API might have been once designed to allow random byte strings
to be used as ids and only converted QString to UTF-8, the current
implementation in many places assumes the byte strings passed via
const char* or QByteArray are also in of UTF-8 encoding
(or at least ASCII7-only).
See e.g. KConfigGroup::entryMap() or KConfigGroup::name().

Stating the supported encoding explicitly should avoid any misassumptions.

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

See https://community.kde.org/Frameworks/Frameworks_Logging_Policy

locationType is used to determine where the config file should be saved.
If it is not passed on to the KConfigSkeleton constructor, the default
(GenericConfigLocation) will be used and any value the application had
set will be ignored.

This makes it follow the pattern of other "Configure X" style
actions. See also the discussion in
kxmlgui!4 (comment 60691)

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

It will assert.

KStandardShortcut::name returns a QString, this makes the api symmetric and more
straightforward to use.

qstrcmp returns 0 if two strings are equal.

Summary:
This is useful for unittests. Example:

```
KCONFIGCORE_EXPORT void reloadUrlActionRestrictions();

void someTestMethod()
{
    KConfigGroup cg(KSharedConfig::openConfig(), "KDE URL Restrictions");
    cg.writeEntry("rule_count", 1);
    cg.writeEntry("rule_1", QStringList{"open", {}, {}, {}, "file", "", "", "false"});
    cg.sync();
    reloadUrlActionRestrictions();

    // Some test for code that uses KUrlAuthorized

    cg.deleteEntry("rule_1");
    cg.deleteEntry("rule_count");
    cg.sync();
    reloadUrlActionRestrictions();
}
```
This is consistent with the fact that other functions used by
KUrlAuthorized are defined here and exported internally.

Test Plan: Used this in a KIO unittest I'm writing for the future OpenUrlJob

Reviewers: aacid, apol, mdawson

Reviewed By: aacid

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D29347

Summary: Following D27059, add `parentGroupName` attribute to `group` element to generate kconfig settings with subgroups

Reviewers: ervin, dfaure, #frameworks, meven

Reviewed By: ervin, meven

Subscribers: apol, meven, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D27133

Summary:
- Fix order of member initialisation (compiling with -Wreorder)
- Use Q_UNUSED where needed
- QAtomicInteger::loadRelaxed() has been available since Qt 5.14

Test Plan: make && ctest

Reviewers: #frameworks, dfaure, apol

Reviewed By: dfaure

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D27158

Summary:
KApiDox & ECMAddQch have been just teached about Q_DECLARE_FLAGS, so the
underlying typedefs are no longer skipped by doxygen, but can be
documented now, allowing links to be generated for these types e.g. when
used as arguments.

The "#" prefix to the enum name in the description text of all the
Q_DECLARE_FLAGS docs seems needed to properly trigger doxygen autolinks.

GIT_SILENT

Summary:
Fix the following bug, if an entry is set on HOME/.config/kdeglobals and on a specific config file like kcmfonts
When you hit restore defaults button and apply, value will be not wrote on the specific file, but then the value is the one from kdeglobals
This patch ensure we write the key to the specific configuration file on those case with an empty value. KConfig will take default value automatically

Test Plan:
Added a test to ensure flag is working
Tested using some KCM to ensure all is working fine

Reviewers: ervin, dfaure, meven, crossi, hchain

Reviewed By: ervin, dfaure, meven

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D28128

Summary:
Add a standard shortcut for this action so it can be synchronized between different apps
and the file dialog; see https://bugs.kde.org/show_bug.cgi?id=262551.

The action in Dolphin also has F8 bound to this, but the definition here only accept two
default shortcuts, and F8 seems kind of random.

CCBUG: 262551

Test Plan: Apply D28803 to KIO and D28804 to Dolphin and test there

Reviewers: dfaure, #frameworks

Reviewed By: dfaure

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D28802

A similar patch was approved in https://phabricator.kde.org/D26102

Summary:
This is an addendum for commit a2774ff5; making the check
tighter.

Test Plan: make && ctest

Reviewers: #frameworks, dfaure, davidedmundson, cfeck, ervin, meven, bport

Reviewed By: dfaure

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D27811

Summary:
Convert license headers to SPDX statements and add
license files as required by REUSE specification.

Reviewers: cgiboudeaux

Reviewed By: cgiboudeaux

Subscribers: ognarb, cgiboudeaux, kde-frameworks-devel

Tags: #frameworks

Maniphest Tasks: T11550

Differential Revision: https://phabricator.kde.org/D27601

It is a small trivial typo about showing same file instead of actual
config file.

REVIEW: D28151

Summary:
Allow to write choices such as :
```
<choices>
    <choice name="enum_name" value="I can't containt (anything)"></choice>
    <choice name="normal_choice"></choice>
</choices>
```

Test Plan: ctest

Reviewers: ervin, bport, crossi, #frameworks

Reviewed By: ervin

Subscribers: ngraham, davidre, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D27463