GitLab

Co-author Kevin Ottens

Task related : Figure out a good UI for the "show which settings have been changed" feature https://phabricator.kde.org/T13008

Part of the aforementioned feature, this patch allow to indicate when a widget bound to a kconfig settings has been changed from its default value.

See plasma/breeze!12

GIT_SILENT

See https://community.kde.org/Frameworks/Frameworks_Logging_Policy

The standard palette of the style can be different than the system pallete.
This is visible for example with the MS Windows 9x style. Unfortunately there
is no explicit way to reset to the system palette, so set the palette to the
one of the default color scheme.

This makes it follow the pattern of other "Configure X" style
actions. See also the discussion in
kxmlgui!4 (comment 60691)

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

We're trying to deprecate the second

I must have forgotten to remove this code when I copied and pasted it
above.

This reverts commit d82db290.
this broken multiple kirigami applications,
besides, the header colors didn't update correctly on window
activate/deactivate, leaving most of the things with a clearly broken
look

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Remove inactive color group block added when the Header ColorSet
was added.

Add TODO comment about replacing WM with Window colors when WM is phased
out.

Summary:
This introduces two concepts: a new color set for Header (or: titlebar?
open question)
and the possibility for a color set to have a different config group (a
sub group) for different states (there, for inactive)

the Header area should probably also going to slowly relace the WM
section of color themes

This is needed for implement properly T10201, this graphical union
between the titlebar and the toolbar.

There is a problem of NColorSets that has been recently added,
because it makes impossible to hard/impossible to
properly add a set in a 100% abi compatible way, strictly speaking it
should be compatible tough keeping NColorSets as the last value, is a
kindof behavior change, though *should* be acceptable (old users would
get the Header value as NColorSets but everything working never the less)

Test Plan: doing a color set with Header group, the proper values get read

Reviewers: #vdg, #plasma, cblack, ndavis

Reviewed By: #vdg, #plasma, cblack, ndavis

Subscribers: davidre, ndavis, cblack, kde-frameworks-devel

Tags: #frameworks

Maniphest Tasks: T10201

Differential Revision: https://phabricator.kde.org/D29232

NO_CHANGLOG

This reverts commit 11186c05.

This reverts commit 14ecec53.

Summary:
Turns out there was an oversight here, in case of an exclusive group
box, the emitter widget is a button inside the group box which can have
any name (this was thus caught by the assert).

So now we also check if the sender is a button and if that's the case we
verify if its in one of the known exclusive group boxes. If yes we use
the group box as reference for the indicator work.

Reviewers: ngraham, davidedmundson, bport, crossi

Reviewed By: ngraham

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D29014

Summary:
Extend KConfigDialogManager internals to insert a small
SettingsStatusIndicator widget next to widgets representing a setting
which is differs from default value.

Test Plan:
Tested it with several widgets based KCMs, namely: qtquicksettings,
desktoppath and screenlocker. Those three have different situations
in term of layouts. Worst case scenario is desktoppath which leads
to the right hand side of the fields moving a bit to fit the indicators
but that's the price to pay for the feature I guess while keeping
things readable.

Here is a screenshot how of it looks on the qtquicksettings KCM:

{F8225745}

Note that the indicators are clickable and reset the field to default value.

Reviewers: ngraham, davidedmundson, meven, crossi, bport, #vdg, ndavis, broulik

Subscribers: alexde, ndavis, iasensio, davidre, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D27540

Summary:
KApiDox & ECMAddQch have been just teached about Q_DECLARE_FLAGS, so the
underlying typedefs are no longer skipped by doxygen, but can be
documented now, allowing links to be generated for these types e.g. when
used as arguments.

The "#" prefix to the enum name in the description text of all the
Q_DECLARE_FLAGS docs seems needed to properly trigger doxygen autolinks.

GIT_SILENT