GitLab

Alex Richardson authored Jul 26, 2021 and Alexander Lohnau committed Jan 16, 2022

This allows explicitly specifying that the target file should be a .json,
whereas the constructor that takes a path will load any kind of metadata.

See also https://phabricator.kde.org/T14778

Alex Richardson authored Jan 08, 2022 and Alexander Lohnau committed Jan 16, 2022

We were storing some of the paths as absolute paths (e.g. for
QPluginLoader-based metadata), but in some cases we were just storing
the path unmodified. For consistency this commit normalizes all paths
that were used for opening a file and adds a test to verify that all
paths are absolute. Path arguments that have not been used for reading
are still stored as passed in.

With 1b8500d2 we have a d-pointer in more situations
than before, consequently checking if the pointer exists can lead to misleading results
and the method returning an empty string.

In the long run the method will become obsolete, see https://phabricator.kde.org/T14778#263270, but
we should not regress it during KF5.

Instead of /usr/include/KF5/kcoreaddons_version.h.

For more details see:
kservice!79

GIT_SILENT

Task: https://phabricator.kde.org/T15109

In case one forgets to add the `SOURCES` option before passing in the files,
we would simply not add them to the library and don't emit any kind of warning.

In case of static plugins we would get a build error, but for dynamic plugins we would
only get a semi-useful error from QPluginLoader that no plugin/metadata could be found.

Considering that the unexpected argument can be a long list of arguments, I don't think
it is worth printing it out. Consumers should check out the docs for the usage information.

Laurent Montel authored Jan 06, 2022 and Volker Krause committed Jan 06, 2022

/usr/lib64/gcc/x86_64-suse-linux/11/../../../../x86_64-suse-linux/bin/ld: ../lib/libautotests_static.a(kcoreaddons_debug.cpp.o):
relocation R_X86_64_32 against `.bss' can not be used when making a shared object; recompile with -fPIC

Alex Richardson authored Dec 29, 2021 and Alex Richardson committed Jan 03, 2022

FreeBSD uses libprocstat (and there is even a #error at the top of this
file for Q_OS_FREEBSD), so these branches are never compiled.

NO_CHANGELOG

In case we try to load a plugin by the path and it does not exist, QPluginLoader::fileName
returns an empty string. In case we want to log the error an empty string is not useful, instead
we want to know what file was originally requested.

This was only needed a few versions ago and disables the new behavior

NO_CHANGELOG

NO_CHANGELOG

- Use auto for iterator types
- More range-for

NO_CHANGELOG

For internal KCMs or internal plugins we sometimes don't need json metadata.
With this new macro we don't need to specify the factory name, just like we don't need to
do in K_PLUGIN_CLASS_WITH_JSON.

Volker Krause authored Dec 28, 2021 and Ahmad Samir committed Dec 29, 2021

In a 6-based build, that location changes.

This way one can catch this case when one does experimental ports to Qt6/KF6.

Emitting deprecation warnings would only annoy consumers, because all of the usages
are for compatibility logic only.

Task: https://phabricator.kde.org/T11584

Previously we were getting the following warning:
```
The package name passed to `find_package_handle_standard_args` (PROCSTAT)
does not match the name of the calling package (Procstat).  This can lead
to problems in calling code that expects `find_package` result variables
(e.g., `_FOUND`) to follow a certain pattern.
```

Ahmad Samir authored Dec 22, 2021 and Alexander Lohnau committed Dec 28, 2021

This restores the old behaviour of putting the plugins .so files in
builddir/bin/<plugin_name_space>, where plugin_name_space is e.g.
"kf5/kio/".

This has the advantage of working as QCoreApplication::libraryPaths()
will pick it up automatically, so if you run a unittest on the CLI,
(without ctest) in gdb ...etc, it'll just work.

This makes error messages more helpful for debugging.

Example:

kf.coreaddons: "Could not load plugin from /home/jpontaoski/kde/usr/lib64/plugins/kisspages/libpage_user.so: Die Bibliothek /home/jpontaoski/kde/usr/lib64/plugins/kisspages/libpage_user.so kann nicht geladen werden: (/home/jpontaoski/kde/usr/lib64/plugins/kisspages/libpage_user.so: undefined symbol: _ZN4Page16staticMetaObjectE)

(after)

vs

kf.coreaddons: "Could not load plugin from /home/jpontaoski/kde/usr/lib64/plugins/kisspages/libpage_user.so"

(before)

This reverts commit 6d696e50.

See: https://phabricator.kde.org/T14164#252322 for the details

We only need to use QT_MAJOR_VERSION in the find_package() calls, however
using the targets after that, we can use the version-less ones.

Thanks to Christophe Giboudeaux for pointing that out.

See: https://doc.qt.io/qt-6/cmake-qt5-and-qt6-compatibility.html

KF5CoreAddonsMacros: Replace "." with "_" for KPLUGINFACTORY_PLUGIN_CLASS_INTERNAL_NAME compile definition

Otherwise we might end up with invalid class names that contain a ".".

This is used in plasma for example the applet "org.kde.plasma.panelspacer"