GitLab

NO_CHANGELOG

NO_CHANGELOG

NO_CHANGELOG

See https://phabricator.kde.org/T13553 for details.
Now deprecation warnings are also emitted at runtime
and the related methods are formally deprecated.

This makes the unit tests less noisy when it is not needed and at the same time it prevents bitrotting.

GIT_SILENT

The concept will be removed in KF6, see https://phabricator.kde.org/T13553.
Also it is not needed in the tests, consequently there is no reason to
keep it and we can remove the noise when searching for occurrences.

- Silence deprecation warnings for already deprecated code
- Fix unused variable in KPluginFactory constructor

The Android build system does not support subfolders inside the libs
folder. This results in no plugins being included in the APK. This uses
the same convention Qt uses for its plugins, namely renaming the
resulting file as:

libplugins_original_path_to_plugin.so

The plugin loading code is ifdef'ed to only use this schema on Android.

- Use QString::at() instead of operator[] to prevent detaching.
- Using QString::startsWith(), less numbers/calculations.
- Some minor code formatting for better readability.

desktoptojson instead of linking kcoreaddons compiles a linked copy of the
desktopfileparser.cpp, and reused the same logging category, yet set a
different logging default (Debug instead of Warning).
Which makes sense as on conversion one is more interested in any issues.

Though that different setup falls flat once one used kdebugsettings or
directly changes defaults in qtlogging.ini, as at that level both
cases get the same default.

This patch...
... introduces a separate logging category for the conversion tool,
so consumers can control both usages separately.
... now generates the respective logging category code
... removes outdated note about updating the unit test

QProcess::pid() is deprecated and the problem that KProcess::pid() solves
is solved by QProcess::processId()

KTextToHTMLHelper ctor takes 4 args, 3 of which have default values, that's
why the code compiled before.

This reverts commit 407f96d8

GIT_SILENT

QStringRef will be gone in Qt6.

A common corner case that the test should cover.

Otherwise it fails with "error: conversion from ‘int’ to ‘QChar’ is ambiguous" when building against Qt6.

It's only used for one function that is behind that flag already.

This allows to build against a Qt that doesn't have QRegExp at all, i.e.
Qt6

NAME_MAX is defined in limits.h/climits.

Getting it through stdio.h was accidental and can blow up any time.

- The returned QStrings were not used

- There was an empty QStringLiteral used. See clazy rule empty-qstringliteral, but in
an equal checks that makes no difference, QTBUG-54505. And because we actually have
a null string, it makes sense to be more explicit and on the safe side with this.

GIT_SILENT

Fix crash when I try to open kmail config