Commit 973de6e8 authored by Volker Krause's avatar Volker Krause
Browse files

Unexport protected methods only needed internally here

Summary:
This will allow us to eventually hide those entirely on the private class
without breaking the ABI. Also, use unique_ptr rather than QScopedPointer
here for consistency among the public classes.

Reviewers: ervin

Subscribers: kde-pim

Tags: #kde_pim

Differential Revision: https://phabricator.kde.org/D28562
parent 3dc269fb
......@@ -11,7 +11,7 @@
#include <KJob>
#include <QScopedPointer>
#include <memory>
class DavJobBasePrivate;
......@@ -77,15 +77,15 @@ protected:
*
* @param code The code to set, should be a valid HTTP response code or zero.
*/
void setLatestResponseCode(int code);
Q_DECL_HIDDEN void setLatestResponseCode(int code);
void setJobErrorText(const QString &errorText);
void setJobError(int jobErrorCode);
void setErrorTextFromDavError();
void setDavError(const Error &error);
Q_DECL_HIDDEN void setJobErrorText(const QString &errorText);
Q_DECL_HIDDEN void setJobError(int jobErrorCode);
Q_DECL_HIDDEN void setErrorTextFromDavError();
Q_DECL_HIDDEN void setDavError(const Error &error);
explicit DavJobBase(DavJobBasePrivate *dd, QObject *parent = nullptr);
QScopedPointer<DavJobBasePrivate> d_ptr;
Q_DECL_HIDDEN explicit DavJobBase(DavJobBasePrivate *dd, QObject *parent = nullptr);
std::unique_ptr<DavJobBasePrivate> d_ptr;
private:
Q_DECLARE_PRIVATE(DavJobBase)
};
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment