1. 18 May, 2022 5 commits
  2. 17 May, 2022 2 commits
    • Arjen Hiemstra's avatar
      Remove KDeclarative instance from QmlObject · bd91cf1f
      Arjen Hiemstra authored
      The only remaining non-deprecated methods of KDeclarative are static, so
      we no longer need an instance to access them.
      bd91cf1f
    • Arjen Hiemstra's avatar
      QmlObject: Use std::shared_ptr to properly track the lifetime of QQmlEngine · fac27b49
      Arjen Hiemstra authored
      The engine passed to QmlObject is potentially shared, either because it
      comes from QmlObjectSharedEngine or because the caller is already using
      it. Since raw pointers do not provide any information about that,
      deprecate the raw pointer constructors and replace them with a
      constructor taking a std::shared_ptr.
      
      This allows QmlObject to properly track if its the first user of the
      QQmlEngine and if so, call KDeclarative::setupEngine on it. It also
      allows it to know if it is the *last* user of the engine, and in that
      case properly cleanup the QNAM factory, without affecting the shared
      engine case.
      
      BUG: 451790
      fac27b49
  3. 15 May, 2022 1 commit
  4. 14 May, 2022 1 commit
  5. 11 May, 2022 1 commit
  6. 09 May, 2022 1 commit
    • Fushan Wen's avatar
      calendareventsplugin: Add support for alternate dates and sub-labels · 72c3f302
      Fushan Wen authored
      Sub-labels are required to show alternate calendar in the calendar
      applet.
      
      Two new signals are added:
      
      1. `subLabelReady`: Emitted when the plugin has loaded the sub-labels.
      2. `alternateDateReady`: Emitted when the plugin has loaded the
         alternate dates.
      
      `SubLabel` struct contains yearLabel, monthLabel and dayLabel, and the
      plugin can specify the priority among Low, Default, High and Urgent for
      a SubLabel.
      
      CCBUG: 429882
      72c3f302
  7. 11 Apr, 2022 1 commit
  8. 09 Apr, 2022 1 commit
  9. 05 Apr, 2022 1 commit
  10. 02 Apr, 2022 1 commit
  11. 15 Mar, 2022 1 commit
  12. 13 Mar, 2022 1 commit
  13. 05 Mar, 2022 1 commit
  14. 19 Feb, 2022 1 commit
  15. 17 Feb, 2022 1 commit
  16. 16 Feb, 2022 1 commit
  17. 07 Feb, 2022 1 commit
    • Nate Graham's avatar
      Improve Open[app]() functions · d146c4fd
      Nate Graham authored
      These functions had divergent code, and openInfoCenter was not working
      properly because it was following the pattern set by openSystemSettings
      which did not work because System Settings' desktop file does not follow
      rDNS style naming, but other ones do.
      
      BUG: 443984
      FIXED-IN: 5.92
      d146c4fd
  18. 05 Feb, 2022 1 commit
  19. 04 Feb, 2022 1 commit
    • Marco Martin's avatar
      proper position for top separator · b61569a6
      Marco Martin authored
      when there is an header on the kcm, show the separator at the proper
      position, ecountering perfectly the scrollbar separator
      
      Also show them as soon there is a scrollbar, as the scrollbar separator
      looks bad when floating
      
      Before:
      
      ![Screenshot_20220204_110037](/uploads/de468d039eb50735003395347e91f703/Screenshot_20220204_110037.png)
      
      After:
      
      ![Screenshot_20220204_105935](/uploads/4eb458a766b84f1306a58a1724b28a69/Screenshot_20220204_105935.png)
      b61569a6
  20. 03 Feb, 2022 4 commits
    • ivan tkachenko's avatar
      [KeySequenceItem] Make keySequence «non-null», «non-undefined» and «non-""» · 0b5bded8
      ivan tkachenko authored
      This property should always be of type QKeySequence and nothing else.
      
      Unfortunately though,
      
      1) QKeySequence is not exported in QML, and even if it were, being a
      QGadget makes it virtually impossible to use as a property type because
      of mind-blowing variety of internal errors from QML engine, such as:
      
          Invalid property assignment: unsupported type "QKeySequence*"
          TypeError: Property 'KeySequence' of object [null] is not a function
          TypeError: Type error
          Error: Cannot assign QKeySequence to QKeySequence*
      
      2) Qt factory methods of QKeySequence are not marked to be Q_INVOKABLE
      from QML side, I had to introduce one in helper class, so that we can
      always construct a valid object (gadget) with an empty sequence instead
      of messing with null / undefined / empty string values as before.
      0b5bded8
    • ivan tkachenko's avatar
      [KeySequenceItem] Fix code style and bump QML imports · 63ce529a
      ivan tkachenko authored
      Fixed whitespaces and formatting; renamed _helper id to just helper;
      replaced some == checks with strict ===, and replaced dynamic/indirect
      parent.keySequence lookup with root.keySequence access (because parent
      is a generic Item, which doesn't have keySequence property).
      
      Among other things, according to MDN docs[1] `+` and `+=` are the
      preferred ways of string concatenation in JavaScript.
      
      [1]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/concat
      63ce529a
    • ivan tkachenko's avatar
      Make QML code depend less on the `kcm` context property · 2c1247d3
      ivan tkachenko authored
      It allows reusing components from org.kde.kcm module in other code which
      is not running in a KCM module. A marginal use-case, but a possible
      one. For example, according to lxr[1] search, the Timer applet is the
      only applet that uses those controls, but still it shouldn't spam logs
      with meaningless 'undefined reference' messages, since mostly
      (without going into applet's general usability concerns) it seems to be
      working perfectly fine.
      
      [1]: https://lxr.kde.org/search?%21v=kf5-qt5&_filestring=&_string=org.kde.kcm
      2c1247d3
    • Jessica Clarke's avatar
      Fix QT_NO_OPENGL build after 66c5bb0e · 04e1f006
      Jessica Clarke authored
      
      
      QOpenGLContext is an incomplete type for QT_NO_OPENGL builds so, whilst
      references and pointers are fine, they cannot be dereferenced (implict
      in the case of references), nor can automatic storage variables be
      declared.
      Co-authored-by: Alex Richardson's avatarAlex Richardson <arichardson.kde@gmail.com>
      04e1f006
  21. 02 Feb, 2022 1 commit
  22. 23 Jan, 2022 2 commits
  23. 20 Jan, 2022 1 commit
  24. 19 Jan, 2022 2 commits
  25. 17 Jan, 2022 1 commit
  26. 15 Jan, 2022 1 commit
  27. 09 Jan, 2022 1 commit
  28. 08 Jan, 2022 1 commit
  29. 07 Jan, 2022 2 commits