KDNSSD Framework merge requestshttps://invent.kde.org/frameworks/kdnssd/-/merge_requests2023-12-16T19:41:05Zhttps://invent.kde.org/frameworks/kdnssd/-/merge_requests/22GIT_SILENT Port to new way of including CI templates2023-12-16T19:41:05ZAlbert Astals CidGIT_SILENT Port to new way of including CI templateshttps://invent.kde.org/frameworks/kdnssd/-/merge_requests/21Bump Qt deprecation level to 6.52023-11-19T13:23:53ZVolker Krausevkrause@kde.orgBump Qt deprecation level to 6.5GIT_SILENTGIT_SILENThttps://invent.kde.org/frameworks/kdnssd/-/merge_requests/20Switch ServiceModel::ServicePtrRole to some positive int number2023-10-11T16:59:27ZFriedrich W. H. KossebauSwitch ServiceModel::ServicePtrRole to some positive int numberNegative role numbers might have worked, but it is not specified if
they are offciailly supported.
With compiler warnings about
> warning: overflow in conversion from 'AdditionalRoles' to 'int'
> changes value from 'ServicePtrRole...Negative role numbers might have worked, but it is not specified if
they are offciailly supported.
With compiler warnings about
> warning: overflow in conversion from 'AdditionalRoles' to 'int'
> changes value from 'ServicePtrRole' to '-1603986978
there is another motivation now to switch to some positive int number
instead, given the ABI can be changed for KF 6.0 now.https://invent.kde.org/frameworks/kdnssd/-/merge_requests/19Remove irrelevant metadata at the top of DBus specifications2023-08-09T13:12:26ZDavid EdmundsonRemove irrelevant metadata at the top of DBus specificationsThis causes compilation errors on Qt 6.7This causes compilation errors on Qt 6.7https://invent.kde.org/frameworks/kdnssd/-/merge_requests/16Add explicit moc includes to sources for moc-covered headers2023-07-01T18:55:47ZFriedrich W. H. KossebauAdd explicit moc includes to sources for moc-covered headers* speeds up incremental builds as changes to a header will not always
need the full mocs_compilation.cpp for all the target's headers rebuild,
while having a moc file sourced into a source file only adds minor
extra costs, due to s...* speeds up incremental builds as changes to a header will not always
need the full mocs_compilation.cpp for all the target's headers rebuild,
while having a moc file sourced into a source file only adds minor
extra costs, due to small own code and the used headers usually
already covered by the source file, being for the same class/struct
* seems to not slow down clean builds, due to empty mocs_compilation.cpp
resulting in those quickly processed, while the minor extra cost of the
sourced moc files does not outweigh that in summary.
Measured times actually improved by some percent points.
(ideally CMake would just skip empty mocs_compilation.cpp & its object
file one day)
* enables compiler to see all methods of a class in same compilation unit
to do some sanity checks
* potentially more inlining in general, due to more in the compilation unit
* allows to keep using more forward declarations in the header, as with the
moc code being sourced into the cpp file there definitions can be ensured
and often are already for the needs of the normal class methods
moc includes generated with script from sdk/kde-dev-scripts!24 + some manual fine-tuning of newlines.
Checked completeness by this running in the toplevel build dir giving `0`:
`find . -name mocs_compilation.cpp -exec cat {} \; | grep "#include" | wc -l`https://invent.kde.org/frameworks/kdnssd/-/merge_requests/15Fix the translation template number (5->6)2023-03-13T22:58:40ZLuigi ToscanoFix the translation template number (5->6)KF5 and KF6 must be co-installable, so change the major version
number integrated into the translation template name.KF5 and KF6 must be co-installable, so change the major version
number integrated into the translation template name.https://invent.kde.org/frameworks/kdnssd/-/merge_requests/14Remove deprecated API and Qt 5 support2023-01-22T13:51:17ZVolker Krausevkrause@kde.orgRemove deprecated API and Qt 5 supporthttps://invent.kde.org/frameworks/kdnssd/-/merge_requests/13.gitlab-ci.yml: enable static builds2022-09-21T11:53:47ZDawid Wrobel.gitlab-ci.yml: enable static buildsFor context, see https://phabricator.kde.org/T15835For context, see https://phabricator.kde.org/T15835https://invent.kde.org/frameworks/kdnssd/-/merge_requests/12Add Qt6 windows CI support2022-09-18T16:12:04ZLaurent MontelAdd Qt6 windows CI supportLaurent MontelLaurent Montelhttps://invent.kde.org/frameworks/kdnssd/-/merge_requests/11Add FreeBSD Qt6 CI support2022-08-25T09:36:15ZLaurent MontelAdd FreeBSD Qt6 CI supportLaurent MontelLaurent Montelhttps://invent.kde.org/frameworks/kdnssd/-/merge_requests/10Use ECMDeprecationSettings2022-06-28T17:11:05ZFriedrich W. H. KossebauUse ECMDeprecationSettings@alex@alexFriedrich W. H. KossebauFriedrich W. H. Kossebauhttps://invent.kde.org/frameworks/kdnssd/-/merge_requests/9Add windows CI2022-05-17T11:48:45ZNicolas FellaAdd windows CIhttps://invent.kde.org/frameworks/kdnssd/-/merge_requests/8Add CI qt6 support2022-01-06T12:31:16ZLaurent MontelAdd CI qt6 supportLaurent MontelLaurent Montelhttps://invent.kde.org/frameworks/kdnssd/-/merge_requests/7Make it compile against qt62021-12-19T18:50:07ZLaurent MontelMake it compile against qt6https://invent.kde.org/frameworks/kdnssd/-/merge_requests/6replace "MacOSX" with "macOS"2021-08-24T19:54:08ZFrederik Schwarzerreplace "MacOSX" with "macOS"https://invent.kde.org/frameworks/kdnssd/-/merge_requests/5Install headers to path prefix matching the C++ namespace KDNSSD2021-06-21T11:41:40ZFriedrich W. H. KossebauInstall headers to path prefix matching the C++ namespace KDNSSDThe headers are in the same folder both in the sources & the install dir,
and the export header is in the same install dir as well.
Backward-compat headers are provided supporting version-controlled
warnings & disabling reusing the macro...The headers are in the same folder both in the sources & the install dir,
and the export header is in the same install dir as well.
Backward-compat headers are provided supporting version-controlled
warnings & disabling reusing the macros provided by
ecm_generate_export_header
There is no backward-compat file for kdnssd_export.h,
it is assumed no 3rd-party explicitly includes it.
Tested with some API consumers, by first toggling either of
```cmake
add_definitions(
#-DKDNSSD_DISABLE_DEPRECATED_BEFORE_AND_AT=0x055400
#-DKDNSSD_DEPRECATED_WARNINGS_SINCE=0x055300
)
```
to trigger warnings or failed builds. As well as then doing the needed adaptions like
```cpp
#include <kdnssd_version.h>
#if KDNSSD_VERSION >= QT_VERSION_CHECK(5, 84, 0)
#include <KDNSSD/RemoteService>
#include <KDNSSD/ServiceBrowser>
#include <KDNSSD/ServiceTypeBrowser>
#else
#include <DNSSD/RemoteService>
#include <DNSSD/ServiceBrowser>
#include <DNSSD/ServiceTypeBrowser>
#endif
```https://invent.kde.org/frameworks/kdnssd/-/merge_requests/4Work/clang format2021-02-27T18:47:56ZAlexander LohnauWork/clang formatAlexander LohnauAlexander Lohnauhttps://invent.kde.org/frameworks/kdnssd/-/merge_requests/3Revert "Switch from custom K_D to Q_DECLARE_PRIVATE_D & Q_D"2021-02-15T16:09:55ZFriedrich W. H. KossebauRevert "Switch from custom K_D to Q_DECLARE_PRIVATE_D & Q_D"Q_DECLARE_PRIVATE_D uses reinterpret_cast with the d member in the
defined methods, which results in bad casting with the multi-inheritance
subclasses of ServiceBasePrivate.
Switch to use KDNSSD_D instead of K_D to reduce risk of potent...Q_DECLARE_PRIVATE_D uses reinterpret_cast with the d member in the
defined methods, which results in bad casting with the multi-inheritance
subclasses of ServiceBasePrivate.
Switch to use KDNSSD_D instead of K_D to reduce risk of potential clashes.
This reverts commit e8f082950a2fcb7b148a1ac568eda9400145da5d.
BUG: 432949
@dfaure @mdawson @arojas
David, I would ask for a follow-up release of kdnssd 5.79, once approved.
Uploading for review while still testing some more locally, but almost sure this is the cause and fix.https://invent.kde.org/frameworks/kdnssd/-/merge_requests/2Replace QStringList forward decl with QtContainerFwd2021-02-01T14:32:41ZNicolas FellaReplace QStringList forward decl with QtContainerFwdThe latter works with Qt6 tooThe latter works with Qt6 toohttps://invent.kde.org/frameworks/kdnssd/-/merge_requests/1Remove obsolete COPYING files2020-08-17T07:25:54ZAndreas Cord-LandwehrRemove obsolete COPYING files