Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • K KDNSSD Framework
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • FrameworksFrameworks
  • KDNSSD Framework
  • Merge requests
  • !5

Install headers to path prefix matching the C++ namespace KDNSSD

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Friedrich W. H. Kossebau requested to merge work/kossebau/fixincludepathprefix into master Jun 16, 2021
  • Overview 0
  • Commits 2
  • Pipelines 0
  • Changes 10

The headers are in the same folder both in the sources & the install dir, and the export header is in the same install dir as well. Backward-compat headers are provided supporting version-controlled warnings & disabling reusing the macros provided by ecm_generate_export_header

There is no backward-compat file for kdnssd_export.h, it is assumed no 3rd-party explicitly includes it.

Tested with some API consumers, by first toggling either of

add_definitions(
    #-DKDNSSD_DISABLE_DEPRECATED_BEFORE_AND_AT=0x055400
    #-DKDNSSD_DEPRECATED_WARNINGS_SINCE=0x055300
)

to trigger warnings or failed builds. As well as then doing the needed adaptions like

#include <kdnssd_version.h>
#if KDNSSD_VERSION >= QT_VERSION_CHECK(5, 84, 0)
#include <KDNSSD/RemoteService>
#include <KDNSSD/ServiceBrowser>
#include <KDNSSD/ServiceTypeBrowser>
#else
#include <DNSSD/RemoteService>
#include <DNSSD/ServiceBrowser>
#include <DNSSD/ServiceTypeBrowser>
#endif
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: work/kossebau/fixincludepathprefix