GIT_SILENT

GIT_SILENT

NO_CHANGELOG

NO_CHANGELOG

In this case we just copy all the strings from one QStringList into a
newly-created QStringList which will be immediately returned. Instead
just return the source QStringList, no need for the intermediate steps
here.

Caught by clazy:
    /kf5/frameworks/kdoctools/src/meinproc.cpp:94:35:
    warning: Don't call QList::first() on temporary
    [-Wclazy-detaching-temporary]
        const QString checkFilename = parser.positionalArguments().first();

Although we know that .first() must be a valid reference by this point
in the code, it's a reference to a temporary and using this reference is
undefined behavior even though QStringList dtor is clearly not going to
do anything with the memory as it is still referenced by `parser`.

But it's undefined behavior all the same and who knows what interesting
optimizations the compiler will cook up for this someday if left
unfixed. Fixed by making the temporary a named variable.

The old htdig option is not listed anywhere now but I don't see that
coming back anytime soon and all the other options are implemented
already.

Commit e44d403c removed the only usage
of this file-local function, which I confirmed with a ripgrep search
across the repository.  Removing this made MyPair and PairList dead code
as well, and these were also removed.

Tested by building, installing, and using the resulting executable to
build kdesrc-build docs, and by ensuring the kdoctools autotests still
pass.

nix package manager provides like homebrew the
right version inside the cmake prefixes it exports

allow to search there, too, like for homebrew

allows to compile unpatched kdoctools with nix
on e.g. nixos

Task tracked at:
teams/frameworks-devs/kf6-workboard#2

Antoni Bella Pérez authored Feb 06, 2022 and Albert Astals Cid committed Feb 06, 2022

Add a new language (pass all tests)

See:
https://kde.org/info/security/advisory-20220131-1.txt
https://mail.kde.org/pipermail/kde-devel/2022-January/000943.html

Needs forwarding the Qt6 build option.

This should fix KF6 CI builds using kdoctools such as kservice,
kconfigwidgets and kpackage.