GitLab

Forward declaring breaks with Qt6

The previous approach of just adding another minute would result in an
invalid QTime within the last 30 seconds of an hour.

This fixes the sun not rising here tomorrow ;)

Even at twice the speed now, this is still relatively slow and would
probably benefit from either a holiday metadata cache or metadata storage
outside of the holiday files. Technically this is even already mostly
there, as part of the file name.

While at it, also mention unexpected performance costs in the docs.

The previous code computed this four times per requested day, the new code
does it four times per requested year. For small date ranges that makes
little difference, if you query this for a whole year the speedup is very
noticeable though.

This was broken so far if we only have a holiday definition for the
corresponding ISO 3166-1 area. Now this is symmetric and also checks
for the ISO 3166-1 code for the requested code.

This allows to use HolidayRegion as a value type, rather than requiring
allocating them on the heap when wanting to change regions during runtime.
More importantly, this opens the way to make it a Q_GADGET and pass it via
QVariant, and thus easily use it from QML directly.

HolidayRegion is immutable after construction, so holding the d pointer in
a shared pointer would be enough, however we need one that doesn't need
extra space over a void* here to not break ABI. Therefore the choice of
QExplicitlySharedDataPointer.

This is needed for example to implement the OSM opening hours specification
(https://wiki.openstreetmap.org/wiki/Key:opening_hours), as attempted in
https://invent.kde.org/vkrause/kopeninghours.

The existing sunrise code has been refactored to support this, and it
should now be very easy to add support for other sun position times such
as astronomical or nautical twilight as well, should that ever be needed.

See https://community.kde.org/Frameworks/Frameworks_Logging_Policy

holidayscannerplan.cpp was patched directly instead of regenerating it,
as newer versions of flex generate quite different code at least by
formatting, so this might have other side effects and thus is avoided.

the urls in the documentation have been moved in over the years.

private headers. we can do what we want

This patch improves upon @shrapnel's work on the accuracy
of the Taiwanese holidays file:

  + Some holidays are determined based on the Lunar Calendar,
    and their specific dates have to be manually specified
    for each year
  + Official holiday names are now used
  + Try to put a holiday in the correct categories

The following has been excluded:

  + Holidays (Festivals) for indigenous peoples (原住民族歲時祭儀)
  + Non-official holidays such as Halloween and Christmas

Differential Revision: https://phabricator.kde.org/D29223

Summary:
The German holiday files now all have a proper country and name
since commits 4bdc6f61
and 8b3f65ed

this patch allows those names to be translated.

also we can see the subdivision code in the regionName
in the case we have a subdivision but no name.
i.e say we have country "XX-YY" but name field is empty
then we have regionName = countyCode(XX)(yy)

Reviewers: vkrause

Reviewed By: vkrause

Subscribers: ltoscano, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D29575