GitLab

Mirco Miranda authored Apr 14, 2022 and Albert Astals Cid committed Apr 14, 2022

- Removed QByteArray resize with potentially large numbers as in merge request !66

Instead of resizing the bytearray to the potential size and then reading
into it, ask the device to read into a bytearray, this way instead of a
crash because we're trying to resize to a too big number we get a nice
  maxSize argument exceeds QByteArray size limit
warning

oss-fuzz/46664

Mirco Miranda authored Apr 11, 2022 and Albert Astals Cid committed Apr 11, 2022

- New format added: Duotone
- Fix float to int conversion round issue

Found by oss-fuzz but still with an unfiled bug number

As suggested by Mirco Miranda

If you have an image that says it's Mono but has 16 as header.depth we
end up doing invalid memory accesses

oss-fuzz/46437

oss-fuzz/46418

oss-fuzz/46407

Mirco Miranda authored Apr 04, 2022 and Albert Astals Cid committed Apr 04, 2022

- Supersedes merge request !55 (PSB support, XMP metadata, ICC color profile, image resolution read)
- Performance improvements: 5 time faster than previous version (tested on a 3.9GB PSB: 9sec instead 47sec)
- New formats support added: INDEXED (8bps), BITMAP (1bps), GRAYSCALE (8, 16, 32bps), RGB (32bps)
- Should fix Bug https://bugs.kde.org/show_bug.cgi?id=397610
- Fix Bug https://bugs.kde.org/show_bug.cgi?id=428238

Mirco Miranda authored Mar 23, 2022 and Albert Astals Cid committed Mar 23, 2022

- Fix parasite "gimp-comment" not set due to null QImage
- Support to parasite "icc-profile" using Qt 5.14+ API
- Added parasite "gimp-image-metadata" as QImage metadata "XML:org.gimp.xml"
- Added a XCF with XML metadata and icc prifile embedded in autotest folder (generated by GIMP 2.10.30)
- Tested with Qt 5.15.2 and Qt 6.2.3 under Windows and Qt 6.2.3 under macOS

Unfortunately none of them pass since it seems they can't load a png,
save it to their format with loseless quality and read it back and get
exactly the same contents than the png

Plug-in can save in 8bit depth now,
previously only 16bit was supported.
Memory and dimension limits were adjusted.

With or height can be above 32k now (up to 64k), but
image should not have more than 256megapixels
(Default memory limit of libavif)

GIT_SILENT

See:
https://kde.org/info/security/advisory-20220131-1.txt
https://mail.kde.org/pipermail/kde-devel/2022-January/000943.html

In Qt5 converting a QByteArray to a QString stops at the first null byte,
in Qt6 the QByteArray size is respected, and trailing null bytes are
therefore included in the final QString. Explicitly determine the length
of the string data to deal with that.