GitLab

GIT_SILENT

This is why the top combo in the file dialog never had more than 5
items (4 default ones + the current URL).

commit f71092c8 (https://phabricator.kde.org/D14666) broke it due
to switching to std::vector and using unsigned ints, turning negative
numbers (for which qMax used to return 0) into very big positive numbers
(thus skipping all items).

sr/ioslaves/*

GIT_SILENT

application/octet-stream == QMimeType::isDefault()

After all it's the mimetype we add later in the hasAllFilesFilter if

And the Qt docu says "use application/octet-stream to show "All Files"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

When opening various types of "executables" (native binaries, .exe files, shell scripts or .desktop files), show a dialog to ask the user whether to run/execute it or open it as text (in the case of text-based ones). This uses ExecutableFileOpenDialog for KIOWidgets.

This is modelled after OpenWithHandlerInterface.

Add unit test to openurljobtest.

Add unit test to openurljobtest.

GIT_SILENT

Compute and compare three hashes in the files :
 - beginning of the files
 - middle of the files
 - end of the file

BUG: 412662
FIXED-IN: 5.72

filenames is never assigned or modified, only read and cleared. Therefore most of parseSelectedUrls is dead code and the whole function is equivalent to urlList.

filenames has a FIXME that I traced back to 911b856cfda305fc97abc6bf90cd9a2ef9d5a85c from 2000 [sic!]. It mentiones "re-enabled the hack to support multi-selection, until we have something better". I guess we do now :)

This way we get the fancy new icon for free. And we can change the text,
icon, and tooltip only when needed.

BUG: 424414
FIXED-IN: 5.73

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Right now when there is more than one file item action, all of them get
dumped into a sub-menu. Because both Konsole and Gwenview install
plugins, and most Plasma installations include these apps, most users
experience the file item action plugins in sub-menu form.

Using a sub-menu when there is more than one item feels a bit excessive.
Showing up to three inline should avoid bloating the menu too much while
still handling the rare cases when there are tons and tons of items

BUG: 424281
FIXED-IN: 5.73

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

For example, cbr, cbz, are different mimes but their comment is "ebook"
so it's good to be able to differentiate between them

The test assumed that slashes would always be appended to dirs, but this is wrong because there is an option that specifies whether or not to append / built into KUrlCompletionPrivate.

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

NO_CHANGELOG

This is a quick fix to a usability issue.

Autosuggestions are made after / is appended to the folder name and pressing enter completes the autosuggetion. These 2 things are not wrong on their own, but they mess with people's heads when combined in this way. This change prevents the autosuggetion from being started when completing directories since it's only activated after the / is appended.

A better, but not so quick fix would be to make it so pressing enter only completes an autosuggestion after a character has been added after the /

BUG: 423739
FIXED-IN: 5.73

See https://community.kde.org/Frameworks/Frameworks_Logging_Policy

Showing just a popupmenu leads to a crash in Qt 5.12.9,
the fix is already in for Qt 5.12.10.

But what happens in real life is showing the main menu, and opening
the submenu, let's not test popup() on a submenu...

See QTBUG-76162, qtbase commit 4220aa78703a, and qtbase commit
3a29996548f.

NO_CHANGELOG

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

BUG: 422238

Otherwise, futimes() succeeds, but the mtime is still made more recent.

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Since commit 23874cab, the "Cookies" KCM writes the option as "Accept For Session" (with spaces), probably by accident, which broke reading the saved setting.
The KCM has been adjusted later on (in commit efeda6c1) to accept both spellings when loading the settings.

But the daemon itself still only understands "AcceptForSession" (without spaces), so it still asks the user what to do with cookies in this case.

This patch applies the same fix to the daemon, so that changing the setting in the KCM actually works as expected.

CCBUG: 386325

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"