GitLab

Ahmad Samir authored Sep 11, 2021 and Albert Astals Cid committed Sep 28, 2021

Now no scrollbars unless you have many rows in the widget. Tested with the
kpropertiesdialogtest app.

Eugene Popov authored Sep 24, 2021 and Felix Ernst committed Sep 24, 2021

This MR adds the ability to show hidden folders in the subdirectories popup, as well as set the order in which they are shown (first or last). The subdirectories popup appears when the user clicks the arrow to the right of the button that represents a path of the URL.

Before it was suggesting the first child directory and causing the following bug:
BUG: 420966

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Ahmad Samir authored Sep 19, 2021 and David Faure committed Sep 19, 2021

NO_CHANGELOG

sys/types.h is available on all the platforms we support currently:
Linux, FreeBSD, Android, Windows

so less cmake checks and #include guards.

The use case here is KFileWidget, even though it sounds weird to add
open-with actions to the open file dialog, it still makes sense if you're
uploading an image to some web site, while picking the image you may want
to open it in a full-fledged viewer; another example, when uploading/attaching
a text file to a bug report or mail client composer, you may want to check
the contents of the file. This is more intuitive than 'open containing folder'
then opening the file.

BUG: 440748
FIXED-IN: 5.87

GIT_SILENT

GIT_SILENT

GIT_SILENT

Reading the code, the menu separators are added explicitly with
QMenu::addSeparator(); most likely the way separators are added changed
some time ago, and that part was left behind?

NO_CHANGELOG

- Refactor parseFiles()
- More range-for
- Use a std::unique_ptr to manage the private class, less explicit new/delete

NO_CHANGELOG

NO_CHANGELOG

NO_CHANGLEOG

NO_CHANGELOG

This reverts commit 7863f595, I was wrong :)

Reading the code some more (in copyjob, file_copy and file_unix), the
permissions arg is '-1' when we shouldn't touch the dest permissions at all,
i.e. leave them as the system default permissions for newly created files
(umask ...etc).

The scenarios are:
- calling KIO::copy() A to B, permissions are preserved by default, i.e. the
  job copies A's permissions to the permissions arg when it calls file_copy
- calling KIO::copy() A to B, and calling setDefaultPermissions(true),
  the job sets the permissions arg to '-1' when it calls file_copy
- calling KIO::file_copy() directly, the you have full control, if you want
  to preserve the permissions use A's permissions as the permissions arg,
  otherwise use '-1' to use the system default permissions

ACL attributes are handled implicitly at the moment, which isn't ideal but
can be improved later on.

BUG: 404777
CCBUG: 103331

FIXED-IN: 5.87

NO_CHANGELOG

This replaces KToolInvocation::invokeMailer,
and builds on top of KApplicationLauncherJob, to launch the
application whose desktop file mentions x-scheme-handler/mailto
and pass it a mailto URL.

KToolInvocation::invokeMailer supported non-standard
syntax in the Exec line like %s for subject, %c for cc etc.
Mostly to launch kmail, and for hand-crafted desktop files.
Nowadays kmail supports mailto URLs, and so do most other email clients
(at least Evolution and mutt do). One exception is Thunderbird
which doesn't support attach= in mailto URLs for security reasons
so we have to use a different command-line for thunderbird (just
like xdg-email does).

Tested kmail, thunderbird and mutt after selecting them in
kcmshell5 componentchooser (though mutt exits before sending
the email, since it's not properly configured).

KF6 task: https://phabricator.kde.org/T14328

This is more safe, since we can't ensure that the caller hasn't filled those
Fields yet.

NO_CHANGELOG

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Those methods were previously copied from file_unix to aclhelpers_p.h to
enable using the same code in KFileItem too.

NO_CHANGELOG

Following the code:
- changing the ACL permissions of a file via KPropertiesDialog
- when the dialog is closed the dirlister which is installed on the view
  (in e.g. Dolphin or the open file dialog) is notified that the item has
  changed
- KCoreDirLister would then call item.refresh(), if the old item had the ACL
  field(s) set, and they would be gone after calling refresh()

BUG: 299155
FIXED-IN: 5.87

So that the same code can be used by file_unix and kfileitem.

Copyright headers are based on:
unmaintained/kdelibs@bed29fc8

NO_CHANGELOG

NO_CHANGELOG

BUG: 442237
FIXED-IN: 5.87

This namespace is only introduced by acl_portability.h header when HAVE_POSIX_ACL
is set to 1.

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

More range-for.

Prefer an index-based for loop to a while loop, incrementing the iterator
in the for statement is more robust than forgetting to do it in the while
loop.

NO_CHANGELOG

- Make it take <sys/extattr.h> into account
- Search for non-standard acl_* functions