Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • K KIO
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 2
    • Issues 2
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 75
    • Merge requests 75
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • FrameworksFrameworks
  • KIO
  • Merge requests
  • !1009

Warning dialogs: Change button text from "Delete" to "Delete Permanently"

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Guilherme Marçal Silva requested to merge raploz/kio:add_delete_permanently into master Oct 23, 2022
  • Overview 8
  • Commits 2
  • Pipelines 4
  • Changes 2

In dialogs where the user is asked whether they want to permanently delete something, It's possible a user might ignore the warning and only focus on the buttons. If they only see "Delete," they might click it thinking it will simply send the files to the trash, and mistakenly delete their files permanently without realizing it.

This commit changes the button text from "Delete" to "Delete Permanently" so the user has another chance to read what they're about to do and avoid performing a destructive action.

@teams/usability

This is my first actual code change, and I mostly copied the code which is a few lines below, changed the title and the icon. If this is not the right way to approach this change please feel free to close this merge request (or help me), as I'm yet to learn enough C++ to contribute with a more complex change. :)

Edited Oct 23, 2022 by Nate Graham
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: add_delete_permanently