Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • K KIO
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 2
    • Issues 2
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 78
    • Merge requests 78
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • FrameworksFrameworks
  • KIO
  • Merge requests
  • !125

kio_trash: remove unnecessarily strict permission check

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged David Faure requested to merge work/dfaure/fix_kio_trash_for_usb_keys into master Sep 10, 2020
  • Overview 7
  • Commits 1
  • Pipelines 0
  • Changes 1

Tested with chmod 0770 /d/.Trash-1000 (where /d is a mount point), kio_trash complained about security checks before this commit, and works with it.

Also tested with a USB key which ends up mounted as type vfat (rw,nosuid,nodev,relatime,uid=1000,gid=100,fmask=0022,dmask=0022,codepage=437,iocharset=iso8859-1,shortname=mixed,showexec,utf8,flush,errors=remount-ro,uhelper=udisks2). After kio_trash creates .Trash-1000 it complained about a "strange filesystem", and while this is still true :), the removal of the code in TrashImpl::initTrashDirectory makes the trash dir on the USB key usable.

BUG: 76380 FIXED-IN: 5.74

@ahmadsamir @apol @aacid

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: work/dfaure/fix_kio_trash_for_usb_keys