Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • K KIO
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 5
    • Issues 5
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 59
    • Merge requests 59
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • FrameworksFrameworks
  • KIO
  • Merge requests
  • !1352

Remove Designer's "." normaloff file data from icon properties in .ui files

  • Review changes

  • Download
  • Patches
  • Plain diff
Open Friedrich W. H. Kossebau requested to merge work/kossebau/dropnormaloff into master Jul 19, 2023
  • Overview 0
  • Commits 1
  • Pipelines 3
  • Changes 2

Qt Designer (accidentally) injected "." file names as fallback when setting theme icon names, which then results in generated code like:

    QIcon icon;
    QString iconThemeName = QString::fromUtf8("edit-paste");
    if (QIcon::hasThemeIcon(iconThemeName)) {
        icon = QIcon::fromTheme(iconThemeName);
    } else {
        icon.addFile(QString::fromUtf8("."), QSize(), QIcon::Normal, QIcon::Off);
    }

Such a "." file name is not documented to serve any purpose, just results in failing icon lookup.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: work/kossebau/dropnormaloff