Skip to content
Commit 2d8010ed authored by David Faure's avatar David Faure
Browse files

autotests: add expected failure on FreeBSD

FAIL!  : JobTest::overwriteOlderFiles(dest_file_older_copying) Compared values are not the same
   Actual   (QFile(destFile).fileTime(QFileDevice::FileModificationTime)): 2021/01/02 10:40:31.000[UTC]
   Expected (QFile(srcFile).fileTime(QFileDevice::FileModificationTime)) : 2021/01/02 10:40:31.193[UTC]

I thought I fixed that in e618d6fd but
apparently not. I'll let someone with access to a FreeBSD system debug it.

CCMAIL: groot@kde.org, kde-freebsd@kde.org
parent aa4e0645
Loading
Loading
Loading
Loading
  • MR submitted; the code path in file_unix.cpp that uses struct timeval is always setting the usec to 0, which seems wrong (well, it uses st_atime, which is the old-old stat field with just seconds, so there's no much you can do there). The whole ifdeffery on OS seems a bit off, I think some smarts around the available fields of struct stat is in order. If st_atim exists and is a struct timespec then it should go to the code path dealing with struct timespec.

  • .. like, exactly the same thing is going to happen with OpenBSD, since the MR adds only Q_OS_FREEBSD to the list. I'll see if I can come up with some SFINAE trickery.

0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment