Skip to content
Commit a4be4323 authored by Ahmad Samir's avatar Ahmad Samir
Browse files

KPropertiesDialog: fix saving changes when editing a .desktop file symlink

Consider the use case of:
/usr/share/applications/foo.desktop is symlink to /opt/someapp/foo.desktop

relativeAppsLocation() was using QFile::canonicalFilePath(), which meant
that foo.desktop would resolve to a file outside /usr/share/applications,
since the code, rightly, expects files in QStandardPaths::ApplicationsLocation
locations, m_sRelativePath would end up being empty, which makes the check in
KFilePropsPlugin::slotCopyFinished() fail, and the .desktop file wouldn't
get copied to ~/.local/share/applications/, and the saving would fail.

BUG: 450727
FIXED-IN: 5.96
parent a12cf2f2
Loading
Loading
Loading
Pipeline #190481 failed with stage
in 23 minutes and 16 seconds
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment