GitLab

When in narrow mode, hide the empty labels so they do not
add their extra height and margins

Otherwise the declarative dream dies.

Fixes #25

Arjen Hiemstra authored Sep 14, 2021 and Nate Graham committed Sep 15, 2021

While section headers may contain controls that need focus, they should
rarely accept focus themselves. Therefore, it makes more sense to
default them to not accepting focus.

Arjen Hiemstra authored Sep 14, 2021 and Nate Graham committed Sep 15, 2021

Enter/return will do the same as clicking on the item, while up/down
match backtab/tab.

Aleix Pol Gonzalez authored Sep 05, 2021 and Aleix Pol Gonzalez committed Sep 06, 2021

It's deprecated and we don't need it anymore.

This matches the timeout used in tst_actiontoolbar and is hopefully
sufficient for tests to work correctly on CI.

Otherwise we may not be in a proper clean state as the application is
still processing events from a previous run.

This allows the loaders to not block other actions while they are
loading, improving startup speed and general item creation speed.

There's no need for DropShadow here, we can replace the background
rectangle with ShadowedRectangle and get shadows for "free".

During page creation, the globalToolBarStyle property may not yet be
properly initialised, which means we load and create ActionButton, then
almost immediately afterwards discard it again once we know for sure
we're using the ToolBar style.

This also unfolds the binding for "actionButtons.active" since it was
really hard to follow.

Felipe Kinoshita authored Jul 29, 2021 and Nate Graham committed Sep 01, 2021

If the aboutData doens't specify a bug address URL it'll open the
"bugs.kde.org" website.

Arjen Hiemstra authored Aug 25, 2021 and Nate Graham committed Aug 31, 2021

Most of the things were there, it just needed some slight fixing.

Also highlighted a QML weirdness where you're apparently allowed to
declare properties with the same name as those from the base class which
creates duplicate properties.

There's no point in duplicating the button text
unless it's not shown

BUG: 441810

GIT_SILENT

This commit adds two components:
* CategorizedSettings, a container for setting actions showing them in a list
view and displaying the actual page next to it.
* SettingAction, each SettingAction given to a CategorizedSettings is used to
declare a specific setting page.

qqc2-desktop-style will then use this hind to enable spellchecking with sonnet

clang-tidy checks:
readability-isolate-declaration and readability-braces-around-statements

KF task: https://phabricator.kde.org/T14729

GIT_SILENT

Since we already have a fallback, we can use the same fallback when
createPlatformTheme returns nullptr. This makes things slightly more
robust and allows plugins to opt into the fallback behaviour for
PlatformTheme.

Arjen Hiemstra authored Aug 10, 2021 and Jonah Brüchert committed Aug 10, 2021

If we do not rate limit, we flood the logs with deprecation warnings. At
the same time, we do want to show these at least once.