GitLab

When in narrow mode, hide the empty labels so they do not
add their extra height and margins

Aleix Pol Gonzalez authored Sep 05, 2021 and Aleix Pol Gonzalez committed Sep 06, 2021

It's deprecated and we don't need it anymore.

When calculating the implicit size hint of a twin layout, we were
not taking into account the Layout boundaries that those items
may have (Layout.maximumWidth and Layout.minimumWidth)

This could result in the layout going to narrow mode, when visually
all of the twin items could fit within the wide mode.

BUG: 434383
FIXED-IN: 5.81

This should fix most of the issues with elements not linking to their inherited element

Nicolas Fella authored Jan 14, 2021 and Nate Graham committed Jan 22, 2021

This line causes a crash when destructing the screenlocker KCM.
It doesn't seem to be caused by reverseTwinsChanged itself but rather by
accessing the Qt object. I don't fully undestand the root cause.

However the call itself appears to be unnecessary since in the line
above we write to reverseTwins and that triggers the changed signal if
needed.

BUG: 431419
BUG: 428461

This reverts commit e5223369.

This commit still caused regressions. Clearly FormLayout label
adjustments need a *lot* more testing before any changes are
made, and changes shouldn't be pushed right before Frameworks
tagging.

BUG: 429115
FIXED-IN: 5.77
CCMAIL: uhhadd@gmail.com

This is the version of commit 4bc88548 that should have been landed when
!159 was merged, not the commit that actually got merged.

Doesn't have the issue mentioned in the revert commit 7eed9092 as a
reason for reverting 4bc88548.

This reverts commit 4bc88548.

This commit breaks FormLayout label alignment. Wrapping will have to be
implemented in a way that does not regress this.

This make the text fields full width and add a bit of top margin to the
label, to make the label look closer to their coresponding text fields.

copy the array by value

is not always possible to define twinlayout bidirectionally.
this makes aware the layout one is twin to about the fact
with internal reversetwins and actualTwinFormLayouts which is
the union between reversetwins and all reversetwins of all reversetwins

Janet Blackquill authored Sep 15, 2020 and Janet Blackquill committed Sep 18, 2020

This adds a property allowing applications to specify how they'd prefer
the label to be aligned in wide mode.

This reverts commit 6a053505 and all
commits that attempt to fix its regressions.

Shaving off a few lines of code is not worth the effort of fixing all
the regressions caused by shaving a few lines of code.

Summary: For loops have been refactored to use more idiomatic JavaScript functions (`filter()`, `some()`, `forEach()`) where appropriate.

Test Plan: Ensure no regressions in modified components

Reviewers: #kirigami, mart

Reviewed By: #kirigami, mart

Subscribers: broulik, ngraham, plasma-devel

Tags: #kirigami

Differential Revision: https://phabricator.kde.org/D28666

Summary:
When a FormLayout is in wide mode, it attempts to
reset the implicitWidth of a GridLayout by assigning undefined to it.
This doesn't work because:
1) Layouts provide their own implicit width
2) You can't reset an implicit size with undefined, hence the error messages obtained from trying to do so

Reviewers: #kirigami, ngraham

Reviewed By: #kirigami, ngraham

Subscribers: ngraham, plasma-devel

Tags: #kirigami

Differential Revision: https://phabricator.kde.org/D28318

Apparently Timer default interval is 1000 :)

Differential Revision: https://phabricator.kde.org/D28308

Allows to mark the section as disabled even when the control itself is not,
e.g. when you have a RowLayout and don't want to disable the entire row.
This was possible with a checkable section but not the plain label buddy variant.

Differential Revision: https://phabricator.kde.org/D27978

Summary:
Convert license statements to SPDX markers and
add license files as required by REUSE specification.

Reviewers: mart, jriddell

Reviewed By: mart

Subscribers: plasma-devel

Tags: #kirigami

Maniphest Tasks: T11550

Differential Revision: https://phabricator.kde.org/D27364

define implicitWidth and width bindings in the states, in
order to not break bindings
BUG:417351

BUG:416860

Summary:
Without this patch, applications will complain about things not
being acceptable for assigning to certain properties, or not
being able to find a property on some objects.

Reviewers: mart

Reviewed By: mart

Subscribers: plasma-devel

Tags: #kirigami

Differential Revision: https://phabricator.kde.org/D26833

Summary:
previously the height of the label was based on the content's height. However this doesn't work in non wide mode. With this change it preserves the previous behaviour in wide mode were it makes sense but uses a constant height in non-wide mode.

Before:
{F7744926}

After:
{F7744929}

Test Plan: FormLayouts with large content items don't have large margins between the items anymore when wideMode = false.

Reviewers: #kirigami, #plasma:_mobile, mart

Reviewed By: #kirigami, #plasma:_mobile, mart

Subscribers: mart, plasma-devel

Tags: #kirigami

Differential Revision: https://phabricator.kde.org/D25175

when we have a simple
Item {
  Kirigami.FormData.isSeparator: true
}

we don't want top padding and that will have 0x0 size.
anything that has an own display, will get a top padding

BUG:405614

Summary:
The Kirigami separator has spacing below it, but not above it when in a Form Layout. This patch adds a check if there is a separator present and if it is, it adds spacing above it.

BUG: 405614

Test Plan:
Before:
{F6775026}

After:
{F6775027}

Reviewers: mart, #kirigami, ngraham

Reviewed By: mart, #kirigami, ngraham

Subscribers: plasma-devel

Tags: #kirigami

Differential Revision: https://phabricator.kde.org/D20585