Icon: Don't try to load empty fallback icons

Jakob Petsovitsrequested to merge
work/jpetso/empty-fallback-icon-no-lookups into master

If the source of a Kirigami.Icon doesn't exist, and its fallback is an empty string, Qt (at least in version 6.11.1) will try to access numerous non-existent paths such as:

  • $prefix/share/icons/breeze/actions/12/.png
  • $prefix/share/icons/breeze/apps/22@2x/.svg

Ideally Qt shouldn't do this. But in Kirigami, an empty icon fallback string is common, and keeping the pixmap empty in this case is an easy shortcut to take early.

This was observed with strace plasma-systemmonitor on app startup.

Merge request reports