Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Kirigami Kirigami
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 21
    • Issues 21
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 47
    • Merge requests 47
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • FrameworksFrameworks
  • KirigamiKirigami
  • Merge requests
  • !355

Two small-ish startup related commits

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Arjen Hiemstra requested to merge work/ahiemstra/startup into master Sep 01, 2021
  • Overview 1
  • Commits 2
  • Pipelines 2
  • Changes 2

Avoid creating then immediately discarding a page's ActionButton instance

During page creation, the globalToolBarStyle property may not yet be properly initialised, which means we load and create ActionButton, then almost immediately afterwards discard it again once we know for sure we're using the ToolBar style.

This also unfolds the binding for "actionButtons.active" since it was really hard to follow.


Don't use DropShadow for overlay drawer handles

There's no need for DropShadow here, we can replace the background rectangle with ShadowedRectangle and get shadows for "free".

Edited Sep 01, 2021 by Arjen Hiemstra
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: work/ahiemstra/startup