Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Kirigami Kirigami
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 21
    • Issues 21
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 45
    • Merge requests 45
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • FrameworksFrameworks
  • KirigamiKirigami
  • Merge requests
  • !900

Page: Fix title delegate elision glitch

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged ivan tkachenko requested to merge work/ratijas/title into master Jan 11, 2023
  • Overview 7
  • Commits 2
  • Pipelines 3
  • Changes 3

Implicitly sized items like QtQuick/Text don't play nicely with Loader, and generally with kinda-recursive bindings on Layout.* properties.

This combination of two fixes does the trick:

  1. Use extra TextMetrics for reliable width/height values.
  2. Round up text's advance width, so that container loader or layout won't ever round it down (which it did with implicitWidth before).

Before:
image

and also can't reproduce now, but I'm pretty sure I got the same glitch in Discover too.

After: No unnecessary eliding occurs, only when there's not enough space.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: work/ratijas/title