1. 23 Jan, 2021 1 commit
    • Konrad Materka's avatar
      Emit NewMenu when new context menu is set. · 628c44c1
      Konrad Materka authored
      When new context menu is beeing set we should notify about it.
      It is possible that the menu is cached on the client side and the menu items ids are the same.
      
      This signal not part of the official standard but already used by Qt
      (starting from Qt 5.11).
      
      CCBUG: 383202
      628c44c1
  2. 19 Jan, 2021 2 commits
  3. 18 Jan, 2021 1 commit
  4. 14 Jan, 2021 1 commit
  5. 12 Jan, 2021 3 commits
    • Nicolas Fella's avatar
      Move notification id handling into KNotification class · ecc24340
      Nicolas Fella authored
      Currently the notification ids are created/tracked in
      notificationmanager. Ids are only assigned after notify has been called.
      This has lead to lots of confusion and ugly workarounds like
      !19.
      
      By moving the handling inside the KNotification class and assigning a
      good id at construction we ensure that we have one from the start.
      
      Having a notification id of -1 is still a relevant special state at the
      end of a notification's lifetime. That should be disentangled in a
      future patch.
      ecc24340
    • Nicolas Fella's avatar
      Fix removing pending notification from queue · d1bb15dc
      Nicolas Fella authored
      If a notification is in the pending queue it is not yet in the
      notifications map. When the notification is then closed we will hit the early return because the id wasn't found.
      
      We need to still remove it from the queue so move the relevant block up.
      
      If the notification is not removed from the queue it will stay as a
      dangling pointer and blow up when the capabilities are queried and we
      reemit the notification.
      
      BUG: 423757
      d1bb15dc
    • Nicolas Fella's avatar
      Remove faulty check · ccf7aa45
      Nicolas Fella authored
      notifications uses DBus ids as keys, comparing that to
      notification->id(), which is a different kind of id, doesn't make sense
      ccf7aa45
  6. 09 Jan, 2021 1 commit
  7. 02 Jan, 2021 1 commit
  8. 19 Dec, 2020 1 commit
  9. 18 Dec, 2020 1 commit
  10. 12 Dec, 2020 1 commit
  11. 11 Dec, 2020 1 commit
  12. 06 Dec, 2020 2 commits
    • Nicolas Fella's avatar
      Add example/test application · 97c74f05
      Nicolas Fella authored
      The purpose of this is twofold. It serves as a code example, but most importantly it can be used to test changes in KNotifications. It is currently very basic, but can be expanded in the future
      97c74f05
    • Nicolas Fella's avatar
      Improve KNotification API docs · 2e61356b
      Nicolas Fella authored
      Summary:
      Various improvements. Better examples, updated coding style for the examples, removed some obsolete things.
      
      There's room for more improvements, but this is a first step
      
      Reviewers: #frameworks, broulik, jucato, cblack
      
      Subscribers: cblack, class, apol, kde-frameworks-devel
      
      Tags: #frameworks
      
      Maniphest Tasks: T12709
      
      Differential Revision: https://phabricator.kde.org/D26918
      2e61356b
  13. 05 Dec, 2020 1 commit
  14. 04 Dec, 2020 1 commit
  15. 30 Nov, 2020 1 commit
    • Nicolas Fella's avatar
      Don't pass transient hint · 2f65c6b1
      Nicolas Fella authored
      Not persistent doesn not imply transient, that is an unrelated property.
      
      There are vaild use cases for transient notifications, but it shouldn't
      be set unconditionally.
      
      BUG: 422042
      2f65c6b1
  16. 29 Nov, 2020 2 commits
  17. 26 Nov, 2020 1 commit
  18. 21 Nov, 2020 1 commit
  19. 16 Nov, 2020 2 commits
  20. 07 Nov, 2020 1 commit
  21. 01 Nov, 2020 2 commits
  22. 31 Oct, 2020 1 commit
  23. 23 Oct, 2020 1 commit
  24. 15 Oct, 2020 1 commit
    • Nicolas Fella's avatar
      Apply some sanity checking to action keys · c58ac885
      Nicolas Fella authored
      In case the notification server sends invalid actions don't forward them to the application.
      
      For example LXDE sends ActionInvoked for the default action even when no default action has been declared.
      
      BUG: 427717
      c58ac885
  25. 13 Oct, 2020 1 commit
  26. 12 Oct, 2020 4 commits
  27. 11 Oct, 2020 1 commit
  28. 10 Oct, 2020 1 commit
  29. 04 Oct, 2020 1 commit
  30. 25 Sep, 2020 1 commit