GitLab

This reverts commit 5eda60b3.

Use a vector-of-values instead of a vector-of-pointers for no
good reason. This is faster, uses less memory, and prevents leaks
like this one:

```
=================================================================
==175053==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 16 byte(s) in 1 object(s) allocated from:
    #0 0x7f9f407caf41 in operator new(unsigned long) /build/gcc/src/gcc/libsanitizer/asan/asan_new_delete.cpp:99
    #1 0x7f9f405d2dc4 in KateMessageLayout::add(QLayoutItem*, KTextEditor::Message::MessagePosition) /home/milian/projects/kf5/src/frameworks/ktexteditor/src/view/kateviewhelpers.cpp:145
    #2 0x7f9f405d2815 in KateMessageLayout::addWidget(QWidget*, KTextEditor::Message::MessagePosition) /home/milian/projects/kf5/src/frameworks/ktexteditor/src/view/kateviewhelpers.cpp:87
    #3 0x7f9f405b3f20 in KTextEditor::ViewPrivate::postMessage(KTextEditor::Message*, QList<QSharedPointer<QAction> >) /home/milian/projects/kf5/src/frameworks/ktexteditor/src/view/kateview.cpp:3673
    #4 0x7f9f404dface in KTextEditor::DocumentPrivate::postMessage(KTextEditor::Message*) /home/milian/projects/kf5/src/frameworks/ktexteditor/src/document/katedocument.cpp:5911
    #5 0x55df19c6d620 in MessageTest::testAutoHide() /home/milian/projects/kf5/src/frameworks/ktexteditor/autotests/src/messagetest.cpp:77
    #6 0x7ffd039e7bbf  ([stack]+0x1fbbf)
    #7 0x55df19c68e82 in MessageTest::qt_static_metacall(QObject*, QMetaObject::Call, int, void**) autotests/messagetest_autogen/UVLADIE3JM/moc_messagetest.cpp:85

Direct leak of 16 byte(s) in 1 object(s) allocated from:
    #0 0x7f9f407caf41 in operator new(unsigned long) /build/gcc/src/gcc/libsanitizer/asan/asan_new_delete.cpp:99
    #1 0x7f9f405d2dc4 in KateMessageLayout::add(QLayoutItem*, KTextEditor::Message::MessagePosition) /home/milian/projects/kf5/src/frameworks/ktexteditor/src/view/kateviewhelpers.cpp:145
    #2 0x7f9f405d2815 in KateMessageLayout::addWidget(QWidget*, KTextEditor::Message::MessagePosition) /home/milian/projects/kf5/src/frameworks/ktexteditor/src/view/kateviewhelpers.cpp:87
    #3 0x7f9f405b3f20 in KTextEditor::ViewPrivate::postMessage(KTextEditor::Message*, QList<QSharedPointer<QAction> >) /home/milian/projects/kf5/src/frameworks/ktexteditor/src/view/kateview.cpp:3673
    #4 0x7f9f404dface in KTextEditor::DocumentPrivate::postMessage(KTextEditor::Message*) /home/milian/projects/kf5/src/frameworks/ktexteditor/src/document/katedocument.cpp:5911
    #5 0x55df19c6a8a2 in MessageTest::testPostMessage() /home/milian/projects/kf5/src/frameworks/ktexteditor/autotests/src/messagetest.cpp:44
    #6 0x7ffd039e7bbf  ([stack]+0x1fbbf)
```

Fixes:
```
/home/milian/projects/kf5/src/frameworks/ktexteditor/src/vimode/modes/normalvimode.cpp: In member function ‘KateVi::Range KateVi::NormalViMode::motionToPreviousSentence()’:
/home/milian/projects/kf5/src/frameworks/ktexteditor/src/vimode/modes/normalvimode.cpp:2854:24: warning: ‘column’ may be used uninitialized in this function [-Wmaybe-uninitialized]
 2854 |         if (column < 0 && !line.isEmpty()) {
      |             ~~~~~~~~~~~^~~~~~~~~~~~~~~~~~
```

CCBUG: 427654

This reverts 88107e4f, since now we require Qt 5.12.

Note that QRegularExpression::wildcardToRegularExpression returns a pattern
anchored with \A and \z.

Highlihting $foo still works.

getPageMargins -> pageLayout().margins()
setPageMargins ( qreal, qreal, qreal, qreal, QPrinter::Unit) -> setPageMargins(QMarginsF, QPageLayout::Unit)
QPrinter::Millimeter -> QPageLayout::Millimeter

When the file is saved and local, we can just ask for the mimetype
directly. We don't need to create a buffer first, which just wastes
time in this context.

=> already preload that stuff if on the fly spellchecking is enabled globally

As the signal was previously not emitted, some animations lingered.
This can be illustrated by trying to paste from an empty buffer in vimode (e.g. "zp)
or by setting 2 marks fast enough (e.g. in vimode, qqmambq@q@q)

this make the distinction between text area and border working for all themes

When an unfilled number register is selected, prepend the text to the numbered registers instead.

All deletes spanning a line/lines are prepended to the numbered registers, after they are put into the chosen register (if any).
Although this contradicts the vim documentation, it is the actual behavior of vim.

After the latest update ktexteditor based editors suddenyl behave
very differently when using "find next/prev selected" without any
selection: Previously, the word under the cursor would get selected.
The current behavior would diretly jump to the next/previous match.

This patch restores the old behavior of first selecting the word
under the cursor. This is part of my muscle-memory and I use it
to quickly select the word under the cursor (ctrl+h once) or find
the next occurance (ctrl+h twice) etc. pp.

ok'd by Friedrich W. H. Kossebau

details see #4