diff --git a/src/view/kateviewhelpers.cpp b/src/view/kateviewhelpers.cpp index ffc7dadf1f41389eb6ab92b11c0a6bd7b8397d64..1174c5e088d7fbee2da65586d1e070b196c3e92e 100644 --- a/src/view/kateviewhelpers.cpp +++ b/src/view/kateviewhelpers.cpp @@ -94,10 +94,7 @@ int KateMessageLayout::count() const QLayoutItem *KateMessageLayout::itemAt(int index) const { - if (index < 0 || index >= m_items.size()) - return nullptr; - - return m_items[index]->item; + return m_items.value(index).item; } void KateMessageLayout::setGeometry(const QRect &rect) @@ -106,9 +103,9 @@ void KateMessageLayout::setGeometry(const QRect &rect) const int s = spacing(); const QRect adjustedRect = rect.adjusted(s, s, -s, -s); - for (auto wrapper : m_items) { - QLayoutItem *item = wrapper->item; - auto position = wrapper->position; + for (const auto &wrapper : qAsConst(m_items)) { + QLayoutItem *item = wrapper.item; + auto position = wrapper.position; if (position == KTextEditor::Message::TopInView) { const QRect r(adjustedRect.width() - item->sizeHint().width(), s, item->sizeHint().width(), item->sizeHint().height()); @@ -134,15 +131,14 @@ QSize KateMessageLayout::sizeHint() const QLayoutItem *KateMessageLayout::takeAt(int index) { if (index >= 0 && index < m_items.size()) { - ItemWrapper *layoutStruct = m_items.takeAt(index); - return layoutStruct->item; + return m_items.takeAt(index).item; } return nullptr; } void KateMessageLayout::add(QLayoutItem *item, KTextEditor::Message::MessagePosition pos) { - m_items.push_back(new ItemWrapper(item, pos)); + m_items.push_back({item, pos}); } // END KateMessageLayout diff --git a/src/view/kateviewhelpers.h b/src/view/kateviewhelpers.h index 06b82f27123d7e2f4429d6322cfab5b1360e17c8..f4f505356e237eae86f3a17cab78543ab2df9bc4 100644 --- a/src/view/kateviewhelpers.h +++ b/src/view/kateviewhelpers.h @@ -83,6 +83,7 @@ private: void addItem(QLayoutItem *item) override; // never called publically struct ItemWrapper { + ItemWrapper() = default; ItemWrapper(QLayoutItem *i, KTextEditor::Message::MessagePosition pos) : item(i) , position(pos) @@ -90,10 +91,10 @@ private: } QLayoutItem *item = nullptr; - KTextEditor::Message::MessagePosition position; + KTextEditor::Message::MessagePosition position = KTextEditor::Message::AboveView; }; - QVector m_items; + QVector m_items; }; /**