Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
K
KTextEditor
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3
    • Issues 3
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 2
    • Merge Requests 2
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Frameworks
  • KTextEditor
  • Merge Requests
  • !40

Merged
Opened Nov 02, 2020 by Jan Paul Batrina@jbatrinaDeveloper

[Vimode] Prevent search box from disappearing

  • Overview 4
  • Commits 1
  • Changes 1

The bug report explains how to reproduce the problem (basically, Ctrl+F two times in succession).

The bug itself comes about in a very roundabout manner (explained in the commit message), but ultimately is caused by EmulatedCommandBar::SwitchToMode calling SearchMode::deactivate even when the newMode is also SearchMode, meaning the search bar is hidden every time. The only change is that EmulatedCommandBar::SwitchToMode just returns and does nothing when newMode == m_currentMode since most of the function is just setting pointers/members.

BUG 368130

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Reference: frameworks/ktexteditor!40
Source branch: vimode-improvements