Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • K KTextEditor
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1
    • Issues 1
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 3
    • Merge requests 3
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • FrameworksFrameworks
  • KTextEditor
  • Merge requests
  • !40

[Vimode] Prevent search box from disappearing

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Jan Paul Batrina requested to merge jbatrina/ktexteditor:vimode-improvements into master Nov 02, 2020
  • Overview 4
  • Commits 1
  • Pipelines 0
  • Changes 1

The bug report explains how to reproduce the problem (basically, Ctrl+F two times in succession).

The bug itself comes about in a very roundabout manner (explained in the commit message), but ultimately is caused by EmulatedCommandBar::SwitchToMode calling SearchMode::deactivate even when the newMode is also SearchMode, meaning the search bar is hidden every time. The only change is that EmulatedCommandBar::SwitchToMode just returns and does nothing when newMode == m_currentMode since most of the function is just setting pointers/members.

BUG 368130

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: vimode-improvements