KTextWidgets merge requestshttps://invent.kde.org/frameworks/ktextwidgets/-/merge_requests2024-01-26T15:44:43Zhttps://invent.kde.org/frameworks/ktextwidgets/-/merge_requests/47Revert "Port to ECMFeatureSummary"2024-01-26T15:44:43ZVolker Krausevkrause@kde.orgRevert "Port to ECMFeatureSummary"This was already ported and thus now broke the build.
This reverts commit de41a9f0d791d3bbe5aca39330e23d0b6da21557.This was already ported and thus now broke the build.
This reverts commit de41a9f0d791d3bbe5aca39330e23d0b6da21557.https://invent.kde.org/frameworks/ktextwidgets/-/merge_requests/46GIT_SILENT Port to new way of including CI templates2023-12-16T23:21:24ZAlbert Astals CidGIT_SILENT Port to new way of including CI templateshttps://invent.kde.org/frameworks/ktextwidgets/-/merge_requests/45Fix unused-result warning in lastIndexOf() call2023-12-16T16:46:48ZDavid FaureFix unused-result warning in lastIndexOf() call[[nodiscard]] is arguably wrong for the lastIndexOf() that takes
an optional pointer to a QRegularExpressionMatch, because we can inspect
that object to see if we had a match.[[nodiscard]] is arguably wrong for the lastIndexOf() that takes
an optional pointer to a QRegularExpressionMatch, because we can inspect
that object to see if we had a match.https://invent.kde.org/frameworks/ktextwidgets/-/merge_requests/44Bump Qt deprecation level to 6.52023-11-21T17:11:51ZVolker Krausevkrause@kde.orgBump Qt deprecation level to 6.5GIT_SILENTGIT_SILENThttps://invent.kde.org/frameworks/ktextwidgets/-/merge_requests/43Make TextToSpeech mandatory with an option() to disable it2023-09-25T21:54:13ZAlbert Astals CidMake TextToSpeech mandatory with an option() to disable ithttps://invent.kde.org/frameworks/ktextwidgets/-/merge_requests/42Always set language after highlighter creation2023-07-13T12:42:32ZKevin FunkAlways set language after highlighter creationBefore this patch, the spell-checking language was not set properly
after a focusInEvent in a read-write KTextEdit.
createHighlighter() is called in the following scenarios:
- When spell-checking gets enabled (via setCheckSpellingEnable...Before this patch, the spell-checking language was not set properly
after a focusInEvent in a read-write KTextEdit.
createHighlighter() is called in the following scenarios:
- When spell-checking gets enabled (via setCheckSpellingEnabled())
- When there is a focus-in-event
- When we set the text edit to read-write
We always need to (re-)apply the language after a new highlighter is set
up in these cases.https://invent.kde.org/frameworks/ktextwidgets/-/merge_requests/41Add explicit moc includes to sources for moc-covered headers2023-06-29T20:23:15ZFriedrich W. H. KossebauAdd explicit moc includes to sources for moc-covered headers* speeds up incremental builds as changes to a header will not always
need the full mocs_compilation.cpp for all the target's headers rebuild,
while having a moc file sourced into a source file only adds minor
extra costs, due to s...* speeds up incremental builds as changes to a header will not always
need the full mocs_compilation.cpp for all the target's headers rebuild,
while having a moc file sourced into a source file only adds minor
extra costs, due to small own code and the used headers usually
already covered by the source file, being for the same class/struct
* seems to not slow down clean builds, due to empty mocs_compilation.cpp
resulting in those quickly processed, while the minor extra cost of the
sourced moc files does not outweigh that in summary.
Measured times actually improved by some percent points.
(ideally CMake would just skip empty mocs_compilation.cpp & its object
file one day)
* enables compiler to see all methods of a class in same compilation unit
to do some sanity checks
* potentially more inlining in general, due to more in the compilation unit
* allows to keep using more forward declarations in the header, as with the
moc code being sourced into the cpp file there definitions can be ensured
and often are already for the needs of the normal class methods
moc includes generated with script from sdk/kde-dev-scripts!24 + some manual fine-tuning of newlines.
Checked completeness by this running in the toplevel build dir giving `0`:
`find . -name mocs_compilation.cpp -exec cat {} \; | grep "#include" | wc -l`https://invent.kde.org/frameworks/ktextwidgets/-/merge_requests/40krichtextedittest fix Use a static QRegularExpression object2023-06-30T22:21:20ZShreevathsa V Mkrichtextedittest fix Use a static QRegularExpression objectFix clazy issue
"autotests/krichtextedittest.cpp:181:15: warning: Don't create temporary QRegularExpression objects. Use a static QRegularExpression object instead [clazy-use-static-qregularexpression]
autotests/krichtextedittest.cpp:223...Fix clazy issue
"autotests/krichtextedittest.cpp:181:15: warning: Don't create temporary QRegularExpression objects. Use a static QRegularExpression object instead [clazy-use-static-qregularexpression]
autotests/krichtextedittest.cpp:223:15: warning: Don't create temporary QRegularExpression objects. Use a static QRegularExpression object instead [clazy-use-static-qregularexpression]".https://invent.kde.org/frameworks/ktextwidgets/-/merge_requests/39Fix the translation template version number (5->6)2023-03-20T22:06:24ZLuigi ToscanoFix the translation template version number (5->6)KF5 and KF6 must be co-installable, so change the major version
number which is part of the translation template name.KF5 and KF6 must be co-installable, so change the major version
number which is part of the translation template name.https://invent.kde.org/frameworks/ktextwidgets/-/merge_requests/38Mark pimpl constructors of public classes as unexported2023-03-18T15:55:30ZFriedrich W. H. KossebauMark pimpl constructors of public classes as unexportedGiven the constructors take an argument type not available for external
users of the API, exporting the symbol with all the price tags is
unneeded.
Also add explicit specifiers where possible and missing so far.Given the constructors take an argument type not available for external
users of the API, exporting the symbol with all the price tags is
unneeded.
Also add explicit specifiers where possible and missing so far.https://invent.kde.org/frameworks/ktextwidgets/-/merge_requests/37Require passing tests on Windows as well2023-02-23T16:30:40ZVolker Krausevkrause@kde.orgRequire passing tests on Windows as wellhttps://invent.kde.org/frameworks/ktextwidgets/-/merge_requests/36Remove support for Qt < 6.42023-02-09T22:02:09ZVolker Krausevkrause@kde.orgRemove support for Qt < 6.4https://invent.kde.org/frameworks/ktextwidgets/-/merge_requests/35Change private d to protected d_ptr, use normal Q_DECLARE_PRIVATE2023-01-29T10:24:53ZFriedrich W. H. KossebauChange private d to protected d_ptr, use normal Q_DECLARE_PRIVATEKF6 TODO--KF6 TODO--https://invent.kde.org/frameworks/ktextwidgets/-/merge_requests/34Bump disabled deprecation levels to Qt 6.4 & KF 5.2402023-01-27T15:12:38ZFriedrich W. H. KossebauBump disabled deprecation levels to Qt 6.4 & KF 5.240https://invent.kde.org/frameworks/ktextwidgets/-/merge_requests/33Drop Qt5 support2023-01-27T14:40:23ZFriedrich W. H. KossebauDrop Qt5 supportPushed branch days ago, but forgot to do the MR :)Pushed branch days ago, but forgot to do the MR :)https://invent.kde.org/frameworks/ktextwidgets/-/merge_requests/32Restore linking to QTextToSpeech2023-01-25T17:36:33ZFriedrich W. H. KossebauRestore linking to QTextToSpeechAvailable with Qt 6.4 again.Available with Qt 6.4 again.https://invent.kde.org/frameworks/ktextwidgets/-/merge_requests/31Drop latest deprecated API2023-01-25T17:35:10ZFriedrich W. H. KossebauDrop latest deprecated APIhttps://invent.kde.org/frameworks/ktextwidgets/-/merge_requests/30Remove all deprecated API up to 5.992023-01-21T22:30:15ZNicolas FellaRemove all deprecated API up to 5.99https://invent.kde.org/frameworks/ktextwidgets/-/merge_requests/29Adapt KRichTextEditTest to Qt 6.42022-12-17T20:12:20ZNicolas FellaAdapt KRichTextEditTest to Qt 6.4The resulting HTML got some extra CSS lines, so the expected line count needs to be changedThe resulting HTML got some extra CSS lines, so the expected line count needs to be changedhttps://invent.kde.org/frameworks/ktextwidgets/-/merge_requests/28Deprecate unused signal KRichTextEdit::selectionFinished2022-11-06T11:37:01ZFriedrich W. H. KossebauDeprecate unused signal KRichTextEdit::selectionFinishedNo longer emitted, left-over from rework in
unmaintained/kdelibs@a49eadad1e0a71da92bbbcacbbdb62abd9e0f85d
Solves the idea of !8 without risking breakage :)
@mlaurent @cullmannNo longer emitted, left-over from rework in
unmaintained/kdelibs@a49eadad1e0a71da92bbbcacbbdb62abd9e0f85d
Solves the idea of !8 without risking breakage :)
@mlaurent @cullmann