GIT_SILENT

GIT_SILENT

NO_CHANGELOG

Defeats the purpose of it being a map.

This is a variation of the patch at:
!4
using Qt::SkipEmptyParts in the QStringList::split() call, and adding a
Q_ASSERT.

BUG: 448868
FIXED-IN: 5.95

BUG: 451278
FIXED-IN: 5.95

That's outside of the app bundle and needs special permissions to write
to. Use the app bundle internal data location instead.

Task tracked at:
teams/frameworks-devs/kf6-workboard#2

GIT_SILENT

Corbin Schwimmbeck authored Feb 28, 2022 and Nate Graham committed Feb 28, 2022

Based on the FDA's metric standard of 5ml and 15ml respectively.
Those are the same conversions stamped onto my equivalent measuring spoons in Europe.

BUG: 450908
FIXED-IN: 5.92

Instead of /usr/include/KF5/kunitconversion_version.h.

For more details see:
kservice!79

GIT_SILENT

This follows similar changes in Unit/UnitCategory.

This follows a similar change to Unit, to address the slicing problems
the current interface causes.

This was built with:
-DQT_MAJOR_VERSION=6 \
-DEXCLUDE_DEPRECATED_BEFORE_AND_AT=5.90.0 \
-DKF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x055a00

All unittests still pass.

Any "real" inheritance would be subject to slicing given Unit instances
are treated as a value type everywhere. As inheritance right now is only
used to bypass access control, use helper methods in UnitPrivate for that
and actually make it a real value type in KF6.

This also marks all dptr access for de-inlining in KF6, which clears the
way for potentially further optimizing this, as the majority of dptr
instances are entirely static data but are currently all dynamically
allocated.

A change along these lines is probably desirable for UnitCategory as well.

This fixes valuetest passing also after the first run (seen e.g. on the
FreeBSD CI).

This made Unit/UnitCategory practically undeletable, as seen for example
by the numerous valgrind/LSAN complaints for the unit tests. To solve this
the reference to UnitCategory inside Unit is now just a raw pointer.

This is unfortunately not the only problem here, UnitCategory being
polymorphic but treated as a value type causes slicing. This works by
chance as the sub-classes only contain logic in their ctor, but have no
member variables or overloaded methods. This is why this solution works,
but the slicing also happened before already.