Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • K KWidgetsAddons
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 11
    • Merge requests 11
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • FrameworksFrameworks
  • KWidgetsAddons
  • Merge requests
  • !160

Make Full Screen action use consistent text and icon

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Nate Graham requested to merge ngraham/kwidgetsaddons:make-fullscreen-action-use-consistent-text-and-icon into master Nov 18, 2022
  • Overview 7
  • Commits 1
  • Pipelines 3
  • Changes 2

This is a checkable action, and right now when unchecked, it shows "Full Screen Mode" but when checked, it shows "Exit Full Screen Mode". The icon changes too.

Changing the text when checked does not make sense and violates the HIG (https://develop.kde.org/hig/components/editing/togglebutton/#behavior).

BUG: 240854 FIXED-IN: 5.101

@teams/vdg @teams/usability

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: make-fullscreen-action-use-consistent-text-and-icon