1. 19 Sep, 2021 5 commits
  2. 17 Sep, 2021 1 commit
    • Nate Graham's avatar
      Revert "Change busywidget to a gear" · 6f8eae0c
      Nate Graham authored
      This reverts commit aafe6523.
      This change has not been well-received by users, and exposes a
      conceptual issue with how app launch animations are currently handled in
      Plasma, with the loading spinner simply re-used as an overlay on top of
      the app icon. This constrains possible designs for the spinner because
      the backgrounds it will be displayed on top of differ gratly in these
      usages; what looks good in one context may not look good in the other.
      We will have to find another way.
      BUG: 442525
      FIXED-IN: 5.87
  3. 16 Sep, 2021 1 commit
  4. 11 Sep, 2021 1 commit
  5. 07 Sep, 2021 1 commit
  6. 05 Sep, 2021 2 commits
  7. 04 Sep, 2021 1 commit
  8. 03 Sep, 2021 2 commits
    • Nate Graham's avatar
      ExpandableListitem: Implement the expanded button view in a better way · a890391f
      Nate Graham authored
      The old implementation of the expanded button view used ListViews full
      of custom content items, with various tricky sizing hacks. This was
      plagued by bugs.
      This commit introduces a new implementation that uses standard
      ToolButtons populated by a Repeater. The result is much better:
      1. Use of standard Plasma components, increasing consistency
      2. Full keyboard navigation between all items now works
      3. Scrolling when there is a lot of content now works properly with no
         stutters because the expanded views no longer have internal
      4. Removed a dependency on PlasmaComponents2
      5. Less code; fewer hidden bugs and less maintenance
      There are practically no visual changes--just incidental things like
      elements moving a few pixels from where they were before due to using
      ToolButtons instead of custom list items.
    • Nate Graham's avatar
      Fix wide button content alignment · 9b447f04
      Nate Graham authored
      ButtonContent.qml sets Layout.fillWidth: true for both the icon and text
      component. This is benign when the button is at its minimum width, but
      if you force the button to be wider than normal (for example, to get it
      to perfectly fit in some space, or to align the heights of a column of
      buttons) then this causes the icon to no longer hug the left edge as
      expected; instead it appears at a random-looking horizontal position
      according to the width of the label relative to the total width of the
      We need to conditionalize this so that it only happens for buttons with
      the text below the icon, or buttons with no text.
  9. 02 Sep, 2021 1 commit
  10. 01 Sep, 2021 1 commit
  11. 31 Aug, 2021 1 commit
  12. 30 Aug, 2021 1 commit
  13. 28 Aug, 2021 2 commits
  14. 27 Aug, 2021 1 commit
  15. 25 Aug, 2021 1 commit
  16. 23 Aug, 2021 4 commits
    • Matt Whitlock's avatar
      avoid holding onto old Svg object when changing source of an IconItem · 73782c8b
      Matt Whitlock authored and Nate Graham's avatar Nate Graham committed
      A long-lived IconItem instance can have its source changed many times
      over its lifetime. Because SvgSource parents its internal Plasma::Svg
      instance to the IconItem instance, this means that such Plasma::Svg
      instance was not being destroyed when its responsible SvgSource
      instance is destroyed and indeed would not be destroyed until the
      IconItem instance is eventually destroyed, which could be arbitrarily
      much later. This commit adds an explicit call in the SvgSource
      destructor to delete the Plasma::Svg instance so it does not hang
      around in memory until the IconItem instance is destroyed. This fixes
      one of the major memory "leaks" in plasmashell.
    • Matt Whitlock's avatar
      don't make duplicate connections to ThemePrivate::onAppExitCleanup · 14b495f9
      Matt Whitlock authored and Nate Graham's avatar Nate Graham committed
      Plasma::Theme::Theme(…) and Plasma::Theme::setThemeName(…) were
      unconditionally connecting the QCoreApplication::aboutToQuit signal to
      the ThemePrivate::onAppExitCleanup slot, even though the ThemePrivate
      instances are cached and shared across multiple Theme instances. In
      long-running applications that make heavy use of the Svg class (such as
      plasmashell), a single ThemePrivate instance can be reused by huge
      numbers of Theme instances. If the reference count of that ThemePrivate
      instance never reaches zero, then the connections just keep piling up,
      contributing to excessive memory usage. This commit moves the relevant
      connect(…) call so that it only happens in the case that a new
      ThemePrivate instance is constructed. Thus, there will only ever be one
      connection from QCoreApplication::aboutToQuit to
      ThemePrivate::onAppExitCleanup per instance of ThemePrivate.
    • Devin Lin's avatar
      [PC3&PC2/TextField] Consistent sizing of clear button with kirigami · 32a20fa8
      Devin Lin authored and Nate Graham's avatar Nate Graham committed
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · ed3f2473
      Script Kiddy authored
      In case of conflict in i18n, keep the version of the branch "ours"
      To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
  17. 22 Aug, 2021 6 commits
  18. 21 Aug, 2021 4 commits
  19. 20 Aug, 2021 2 commits
  20. 19 Aug, 2021 2 commits