Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • K KDE Plasma Framework
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 6
    • Issues 6
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 29
    • Merge requests 29
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • FrameworksFrameworks
  • KDE Plasma Framework
  • Merge requests
  • !555

Units: Fix sizeForLabels double-scaling icons with Plasma scaling

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Nate Graham requested to merge ngraham/plasma-framework:fix-size-for-labels into master Jun 23, 2022
  • Overview 0
  • Commits 1
  • Pipelines 3
  • Changes 1

The sizeForLabels unit internally uses roundToIconSize(), giving it a value and feeding that into devicePixelIconSize() to take into account required icons size differences when using Plasma scaling. But roundToIconSize() internally does that automatically! So as a result, the size is double-scaled and looks too big. To fix this, we simply have to stop using devicePixelIconSize() for this unit.

Before After
Before After

@ndavis

BUG: 454131 FIXED-IN: 5.96

Edited Jun 23, 2022 by Nate Graham
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix-size-for-labels