Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • P Purpose framework
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1
    • Issues 1
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 7
    • Merge requests 7
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Frameworks
  • Purpose framework
  • Merge requests
  • !13

Open
Created Aug 28, 2020 by Nicolas Fella@nicolasfellaDeveloper
  • Report abuse
Report abuse

Let JobController take ownership of the configuration

  • Overview 3
  • Commits 1
  • Changes 4

Previously the configuration was parented to the AlternativesModel. This was introduced in 262ffe80 which was a behavioral change given that previously ownership was transferred to the caller and therefore arguably should not have happend.

Binding the Configuration lifetime to the AlternativesModel lifetime is undesirable since one AlternativesModel can be used to create several jobs.

Binding it to the controller, which is designed to be used for a single job makes more sense.

To avoid another behavioural change a new method is introduced. To indicate that ownership is transferred to the caller a unique_ptr is returned.

Edited Aug 29, 2020 by Nicolas Fella
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: work/configowner