Commit 2c777b1b authored by Kai Uwe Broulik's avatar Kai Uwe Broulik 🍇

[ComboBox] Use transparent dimmer

When not using dim it breaks "click outside" for ComboBox in certain views.
It appears to be mostly scrollable KCMs due to the way we embed them.
So we keep dim on but use a transparent Item to avoid it actually dimming its surroundings.

Differential Revision: https://phabricator.kde.org/D27701
parent 3547aa50
......@@ -196,9 +196,15 @@ T.ComboBox {
Kirigami.Theme.colorSet: Kirigami.Theme.View
Kirigami.Theme.inherit: controlRoot.Kirigami.Theme.inherit
modal: true
dim: false
dim: true
closePolicy: Controls.Popup.CloseOnEscape | Controls.Popup.CloseOnPressOutside
// Forces it to have a transparent dimmer.
// A dimmer is needed for "click outside" to work reliably in some views
// but default dimmer would, well, dim the contents in pure QtQuick windows,
// like ApplicationWindow, which we don't want.
Controls.Overlay.modal: Item { }
contentItem: ListView {
id: listView
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment