GitLab

Summary:
Whenever qqc release a new version the version need to be updated.
Otherwise the feature is not available to user. This change tries
to use real qml code to detect the version by creating object until
success, force to use a minimal qpa platform when running it.

Test Plan:
Run the cmake under a env without display server and version is detected
correctly.

Reviewers: #plasma, rizzitello, davidedmundson, apol, mart

Reviewed By: #plasma, davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D28859

When not using dim it breaks "click outside" for ComboBox in certain views.
It appears to be mostly scrollable KCMs due to the way we embed them.
So we keep dim on but use a transparent Item to avoid it actually dimming its surroundings.

Differential Revision: https://phabricator.kde.org/D27701

Summary:
Convert license headers to SPDX expressions and add license texts
as required by REUSE specification.

Reviewers: ngraham, davidedmundson

Reviewed By: ngraham, davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Maniphest Tasks: T11550

Differential Revision: https://phabricator.kde.org/D28382

Instead of expensive DropShadow layer.

Differential Revision: https://phabricator.kde.org/D28156

KQuickStyleItem manages its implicit size internally. Overriding it on the QML side makes it non-deterministic
which assignment wins and might cause unexpected re-evaluation of the size causing it to change.

Moreover, the CheckIndicator implicit size is based on sizeFromContents for CT_CheckBox, which in case of Breeze
(but not the Qt built-in styles) already contains some extra padding on the side between checkbox and label.
Instead of using that for layouting our full checkbox (indicator + label), do what qqc1 did and use
PM_CheckBoxLabelSpacing for spacing and PM_IndicatorWidth as size hint for the indicator.

Also while at it for radio buttons use the appropriate (PM_RadioButtonLabelSpacing and PM_ExclusiveIndicatorWidth) hints.

This makes QQC2 CheckBox and RadioButton layouted pixel-perfect to their QWidget counterparts and also fixes
it randomly changing size hints as you switch between pages as demonstrated by the bug report.

BUG: 418447

Differential Revision: https://phabricator.kde.org/D28116

Instead of expensive DropShadow layer.

Differential Revision: https://phabricator.kde.org/D28029

Summary:
Apparently I accidentally used the bottom scrollbar width instead of
height. Oops.

Test Plan: ScrollView with horizontal scrollbar no longer hides content

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27280

Summary:
Now that we no longer overlap scrollbars, we can get rid of all the workarounds
needed to make the overlapping scrollbars work. This gets rid of the workarounds
in ItemDelegate and related items.

Test Plan:
Before: Too much padding on the right side
{F7884087}

After: Correct padding
{F7884088}

Reviewers: #plasma, ngraham, mart

Reviewed By: #plasma, ngraham, mart

Subscribers: ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D26686

Summary:
In the Window Decorations and Audio KCMs we use QQC2 TabBars with a frame.

The frame already draws a top border but then the tabbar draws another border, resulting in an ugly, dark, out of place line.

This patch removes the frame from the QQC2 TabBar style to fix the issue.

Test Plan:
Before:
{F7787544}

After:
{F7787554}

Reviewers: #plasma, #vdg, ngraham, broulik, mart

Reviewed By: #plasma, #vdg, ngraham, mart

Subscribers: mart, ahiemstra, broulik, ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D25584

Summary: Buttons colored with special text role colors as backgrounds don't always look nice with black text on light themes. They should have been using background role colors for the background, but the background role colors they needed weren't available. This patch adds the missing background role colors.

Reviewers: #plasma, #kirigami, mart

Reviewed By: #plasma, #kirigami, mart

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D26745

dynamically adapt the scrollbar to an indicator when interacting
with touch

Summary:
when on mobile (or just "tabletmode" the scrollbar goes to "not interactive"
in that case it draws like a typical mobile scroll indicator, overlayed to the
view and disappearing

tough, it still shows a couple of pixels line when not in use so the users always
knows where in the view they are

Test Plan:
desktop:
{F7882608}

mobile:
{F7882610}

Reviewers: #plasma, #vdg, #kirigami, ngraham

Reviewed By: #vdg, ngraham

Subscribers: broulik, plasma-devel

Tags: #plasma

Maniphest Tasks: T9126

Differential Revision: https://phabricator.kde.org/D26654

Summary:
This ensures the scrollbar of a ScrollView do not overlap the ScrollView's
contents. It effectively makes ScrollView's behaviour the same as all
widget views, which also do not overlap the contents.

It also removes the need for a lot of workarounds in applications and other
places to fix the overlapping problem.

Test Plan:
Tested with this QML:
```
import QtQuick 2.12
import QtQuick.Controls 2.12

import org.kde.kirigami 2.11 as Kirigami

Kirigami.ApplicationWindow {
    pageStack.initialPage: Kirigami.Page {
        leftPadding: 0
        rightPadding: 0
        topPadding: 0
        bottomPadding: 0
        ScrollView {
            anchors.fill: parent

            ListView {
                model: 100

                delegate: ItemDelegate {
                    width: ListView.view.width
                    text: modelData
                }
            }
        }
    }
}
```

Before: {F7871128}

After: {F7875125}

Reviewers: #plasma, #goal_consistency, mart

Reviewed By: #plasma, mart

Subscribers: kmaterka, mart, ndavis, IlyaBizyaev, ngraham, broulik, plasma-devel

Tags: #plasma

Maniphest Tasks: T9126

Differential Revision: https://phabricator.kde.org/D26530

Otherwise screws up font rendering

Differential Revision: https://phabricator.kde.org/D26403

Ensures controls update their size when font changes.
The Labels inside would but the control around them not,
leading to broken rendering until causing it to update by interacting with it.
It has to be queued for some reason or else by the time the signal is invoked,
the style hasn't caught up yet.

Differential Revision: https://phabricator.kde.org/D25983

Summary: Also no longer create unused file qqc2desktopstyle_version.h

Reviewers: mart, broulik, davidedmundson, apol

Reviewed By: davidedmundson, apol

Subscribers: apol, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D23005

Summary: Compile against 5.14 without deprecated method

Reviewers: apol

Reviewed By: apol

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D25709

Summary:
If some color scheme (not Breeze) doesn't use the same button and window colors the tab sticks out.

BUG: 413311
FIXED-IN: 5.65

Test Plan:
Before:
{F7787513}
After:
{F7787516}

Reviewers: #plasma, #vdg, ngraham

Reviewed By: #vdg, ngraham

Subscribers: davidre, broulik, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D25581

This mimics QToolTip behavior and ensures the tooltip is actually readable.
The property naming is quite confusing:
* delay is the delay until the tooltip shows when visible becomes true
* timeout is the timeout until the tooltip hides regardless of whether visible is still true!
  It is not a delay after visible becomes false

Differential Revision: https://phabricator.kde.org/D25406