1. 09 Jun, 2020 1 commit
    • Noah Davis's avatar
      Fix Slider vertical implicitWidth and a binding loop · c2497012
      Noah Davis authored
      The implicitWidth was using the horizontal implicitWidth for vertical
      sliders, which is way too wide.
      The binding loops was fixed just by specifying an id for the implicitWidth value used for contentWidth.
      c2497012
  2. 08 Jun, 2020 3 commits
  3. 06 Jun, 2020 2 commits
  4. 05 Jun, 2020 1 commit
  5. 25 May, 2020 2 commits
  6. 19 May, 2020 1 commit
  7. 09 May, 2020 2 commits
  8. 04 May, 2020 1 commit
  9. 02 May, 2020 1 commit
  10. 20 Apr, 2020 1 commit
    • Xuetian Weng's avatar
      Detect QQC2 version at build time with actual detection. · aa57b34f
      Xuetian Weng authored
      Summary:
      Whenever qqc release a new version the version need to be updated.
      Otherwise the feature is not available to user. This change tries
      to use real qml code to detect the version by creating object until
      success, force to use a minimal qpa platform when running it.
      
      Test Plan:
      Run the cmake under a env without display server and version is detected
      correctly.
      
      Reviewers: #plasma, rizzitello, davidedmundson, apol, mart
      
      Reviewed By: #plasma, davidedmundson
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D28859
      aa57b34f
  11. 14 Apr, 2020 1 commit
  12. 11 Apr, 2020 1 commit
  13. 04 Apr, 2020 1 commit
  14. 29 Mar, 2020 1 commit
  15. 24 Mar, 2020 1 commit
  16. 20 Mar, 2020 1 commit
  17. 18 Mar, 2020 1 commit
    • Kai Uwe Broulik's avatar
      Fix sizing of CheckBox and RadioButton · b738ebbb
      Kai Uwe Broulik authored
      KQuickStyleItem manages its implicit size internally. Overriding it on the QML side makes it non-deterministic
      which assignment wins and might cause unexpected re-evaluation of the size causing it to change.
      
      Moreover, the CheckIndicator implicit size is based on sizeFromContents for CT_CheckBox, which in case of Breeze
      (but not the Qt built-in styles) already contains some extra padding on the side between checkbox and label.
      Instead of using that for layouting our full checkbox (indicator + label), do what qqc1 did and use
      PM_CheckBoxLabelSpacing for spacing and PM_IndicatorWidth as size hint for the indicator.
      
      Also while at it for radio buttons use the appropriate (PM_RadioButtonLabelSpacing and PM_ExclusiveIndicatorWidth) hints.
      
      This makes QQC2 CheckBox and RadioButton layouted pixel-perfect to their QWidget counterparts and also fixes
      it randomly changing size hints as you switch between pages as demonstrated by the bug report.
      
      BUG: 418447
      
      Differential Revision: https://phabricator.kde.org/D28116
      b738ebbb
  18. 16 Mar, 2020 1 commit
  19. 12 Mar, 2020 1 commit
  20. 07 Mar, 2020 2 commits
  21. 06 Mar, 2020 1 commit
  22. 12 Feb, 2020 1 commit
  23. 10 Feb, 2020 1 commit
  24. 09 Feb, 2020 2 commits
  25. 01 Feb, 2020 1 commit
  26. 27 Jan, 2020 1 commit
    • Arjen Hiemstra's avatar
      Remove scrollbar related workarounds from list delegates · 9dfb3817
      Arjen Hiemstra authored
      Summary:
      Now that we no longer overlap scrollbars, we can get rid of all the workarounds
      needed to make the overlapping scrollbars work. This gets rid of the workarounds
      in ItemDelegate and related items.
      
      Test Plan:
      Before: Too much padding on the right side
      {F7884087}
      
      After: Correct padding
      {F7884088}
      
      Reviewers: #plasma, ngraham, mart
      
      Reviewed By: #plasma, ngraham, mart
      
      Subscribers: ngraham, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D26686
      9dfb3817
  27. 24 Jan, 2020 1 commit
    • Filip Fila's avatar
      [TabBar] Remove frame · 2ecfa27b
      Filip Fila authored
      Summary:
      In the Window Decorations and Audio KCMs we use QQC2 TabBars with a frame.
      
      The frame already draws a top border but then the tabbar draws another border, resulting in an ugly, dark, out of place line.
      
      This patch removes the frame from the QQC2 TabBar style to fix the issue.
      
      Test Plan:
      Before:
      {F7787544}
      
      After:
      {F7787554}
      
      Reviewers: #plasma, #vdg, ngraham, broulik, mart
      
      Reviewed By: #plasma, #vdg, ngraham, mart
      
      Subscribers: mart, ahiemstra, broulik, ngraham, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D25584
      2ecfa27b
  28. 20 Jan, 2020 1 commit
    • Noah Davis's avatar
      Add active, link, visited, negative, neutral and positive background colors · ae9c5c08
      Noah Davis authored
      Summary: Buttons colored with special text role colors as backgrounds don't always look nice with black text on light themes. They should have been using background role colors for the background, but the background role colors they needed weren't available. This patch adds the missing background role colors.
      
      Reviewers: #plasma, #kirigami, mart
      
      Reviewed By: #plasma, #kirigami, mart
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D26745
      ae9c5c08
  29. 16 Jan, 2020 2 commits
  30. 15 Jan, 2020 2 commits
    • Marco Martin's avatar
      always round x and y · ed98b6ae
      Marco Martin authored
      ed98b6ae
    • Marco Martin's avatar
      support mobile mode scrollbar · 471213f7
      Marco Martin authored
      Summary:
      when on mobile (or just "tabletmode" the scrollbar goes to "not interactive"
      in that case it draws like a typical mobile scroll indicator, overlayed to the
      view and disappearing
      
      tough, it still shows a couple of pixels line when not in use so the users always
      knows where in the view they are
      
      Test Plan:
      desktop:
      {F7882608}
      
      mobile:
      {F7882610}
      
      Reviewers: #plasma, #vdg, #kirigami, ngraham
      
      Reviewed By: #vdg, ngraham
      
      Subscribers: broulik, plasma-devel
      
      Tags: #plasma
      
      Maniphest Tasks: T9126
      
      Differential Revision: https://phabricator.kde.org/D26654
      471213f7
  31. 14 Jan, 2020 1 commit
    • Arjen Hiemstra's avatar
      ScrollView: Do not overlay scrollbars over contents · 06d4bb0e
      Arjen Hiemstra authored
      Summary:
      This ensures the scrollbar of a ScrollView do not overlap the ScrollView's
      contents. It effectively makes ScrollView's behaviour the same as all
      widget views, which also do not overlap the contents.
      
      It also removes the need for a lot of workarounds in applications and other
      places to fix the overlapping problem.
      
      Test Plan:
      Tested with this QML:
      ```
      import QtQuick 2.12
      import QtQuick.Controls 2.12
      
      import org.kde.kirigami 2.11 as Kirigami
      
      Kirigami.ApplicationWindow {
          pageStack.initialPage: Kirigami.Page {
              leftPadding: 0
              rightPadding: 0
              topPadding: 0
              bottomPadding: 0
              ScrollView {
                  anchors.fill: parent
      
                  ListView {
                      model: 100
      
                      delegate: ItemDelegate {
                          width: ListView.view.width
                          text: modelData
                      }
                  }
              }
          }
      }
      ```
      
      Before: {F7871128}
      
      After: {F7875125}
      
      Reviewers: #plasma, #goal_consistency, mart
      
      Reviewed By: #plasma, mart
      
      Subscribers: kmaterka, mart, ndavis, IlyaBizyaev, ngraham, broulik, plasma-devel
      
      Tags: #plasma
      
      Maniphest Tasks: T9126
      
      Differential Revision: https://phabricator.kde.org/D26530
      06d4bb0e