- 24 Jan, 2023 2 commits
-
-
Nicolas Fella authored
-
Volker Krause authored
-
- 23 Jan, 2023 1 commit
-
-
Nicolas Fella authored
-
- 22 Jan, 2023 1 commit
-
-
Volker Krause authored
That's on by default in Qt 6 and the attribute doesn't exist anymore.
-
- 21 Jan, 2023 1 commit
-
-
Nicolas Fella authored
-
- 20 Jan, 2023 2 commits
-
-
Nicolas Fella authored
-
Nicolas Fella authored
-
- 19 Jan, 2023 1 commit
-
-
Nicolas Fella authored
-
- 18 Jan, 2023 2 commits
-
-
Nicolas Fella authored
master is for Qt6-based development now Qt5 development continues in the 'kf5' branch
-
Nicolas Fella authored
master is Qt6 now
-
- 09 Jan, 2023 10 commits
-
-
ivan tkachenko authored
Theoretically, this allows using tinted transparent colors for better transitions: even if alpha is set to zero QtQuick would still animate r, g and b components instead of defaulting to textColor of a theme. On practice, however, qqc2-desktop-style/breeze does not seem to take alpha channel into account, so icons always look like if the alpha was 1.
-
ivan tkachenko authored
-
ivan tkachenko authored
This was clearly a copy-paste mistake from ToolButton. There is no `flat` property on DelayButton, and it was missing that last `|| controlRoot.highlighted` part. Likewise, `highlighted` property is exclusive to Buttons, which DelayButton does not inherit from, thus no need to port it here either.
-
ivan tkachenko authored
Assigning to a property in a tight loop is inefficient. Better create some local variables for such purpose. Note that once set to true, neither of those two properties can reset back to false. This is probably due to the fact that the code deals with only visible subset of a ListView's delegates.
-
ivan tkachenko authored
In fact, they already shared all the required code except this switch. BUG: 442986
-
ivan tkachenko authored
Just remove magic `- 1` adjustment. Seems to be perfectly fine without it.
-
ivan tkachenko authored
-
ivan tkachenko authored
Basically, a copy-paste code from CheckBox/Button/etc. The only difference is the choice of pixel metrics: QStyle::PM_TabBarIconSize.
-
ivan tkachenko authored
Here are the rules: 1. AbstractButton::icon is a grouped property. It can not be used as a conditional expression by itself as it would be quite pointless, because it's always considered truthy like any normal object in js. 2.a. icon.name is a string, which itself can be compared to an empty string "", or its .length property compared to zero. 2.b. icon.source is a QUrl, or a `url` as QmlEngine likes to call it. It is an opaque object for JavaScript environment, which provides magical toString() method that makes it look like a string in some contexts. Strict equality with real strings will fail, as well as attempts to access its .length directly. Empty url converts to an empty string. 2.c. KQuickStyleItem accepts both strings and urls as `properties["icon"]` value. 4. Other sub-properties of icon are always present and default to some values such as 0 size and transparent color.
-
ivan tkachenko authored
A little copy-pasta from a generic Button code above.
-
- 07 Jan, 2023 1 commit
-
-
Script Kiddy authored
-
- 13 Dec, 2022 2 commits
-
-
Fix clazy issue "plugin/kquickstyleitem.cpp:1902:109: warning: Use multi-arg instead [clazy-qstring-arg]".
-
Script Kiddy authored
-
- 12 Dec, 2022 3 commits
-
-
Noah Davis authored
Just a bit more modern and comprehensive, but should look the same.
-
Noah Davis authored
-
Noah Davis authored
Makes the indicators feel more like bullet points when using multi-line labels. Also makes it easier to find the first line of the label for the givent CheckBox/RadioButton/Switch.
-
- 11 Dec, 2022 1 commit
-
-
Noah Davis authored
set `Accessible.role: Accessible.ButtonMenu` on a Button or ToolButton to tell KQuickStyleItem that the button should be a menu button. You can still use the old way of setting background.showMenuArrow to true in onCompleted for ToolButton.
-
- 03 Dec, 2022 1 commit
-
-
Script Kiddy authored
-
- 02 Dec, 2022 1 commit
-
-
Fushan Wen authored
If touch input is detected, TextArea should also allow to be scrolled by touch input regardless of whether tablet mode is disabled. This helps people whose device has small screens and have to disable tablet mode. CCBUG: 461016
-
- 01 Dec, 2022 1 commit
-
-
David Edmundson authored
QQC2 desktop style renders output of breeze into a temporary image. If the DPR changes this needs to be refereshed.
-
- 28 Nov, 2022 2 commits
-
-
This MR improves the background color for better contrast for unchecked state. Basically it darkens the color in light mode and lighten the color in dark mode. In brief the changes are: 1. The background is made better 2. The layer is enabled only when needed
-
Arjen Hiemstra authored
Parsing config and creating a new style for every instance is an incredibly expensive operation that shouldn't be done every time an instance is created. Moreover, the current code makes little sense to me as it completely removes the reason for storing things in a static in the first place. Instead, just initialise the static style once and use that static for consecutive instances. This reduces the time needed to create an instance of Button from over 7ms(!) to around 0.4ms. As an additional bonus, store the style instance in a shared_ptr so we don't need to memory manage it.
-
- 25 Nov, 2022 1 commit
-
-
David Edmundson authored
QQuickWindow::devicePixelRatio doesn't take into account being inside a QQuickWidget or other render target. This matters if the window dpr differs from the screen dpr, something we see on wayland. QQuickWindow has another similarly named method which does, with docs stating this is the one that should always be used.
-
- 18 Nov, 2022 1 commit
-
-
ivan tkachenko authored
Another case solved, Dr. Watson. The reason was that QUrl is an "object" for QML engine, and non-strict equality operator simply converts it toString() beforehand. Icon source is a url, icon name is already a string. Let's convert and compare explicitly and without dark magic.
-
- 17 Nov, 2022 1 commit
-
-
Switch control currently does not look good. This commit improves it to be based on a combination of the Breeze Blue Ocean mockup and the existing implementation in in qqc2-breeze-style.
-
- 14 Nov, 2022 1 commit
-
-
Script Kiddy authored
-
- 11 Nov, 2022 1 commit
-
-
It's unsettling when it happens because you get a very suspicious-looking floating rectangle.
-
- 06 Nov, 2022 1 commit
-
-
ivan tkachenko authored
Apart from ruthlessly copying code from there, also drop unused spacing and set inheritable property hoverEnabled to false to preserve some resources. Content Items's id was unused, to it was removed as well, and a new MR is pending for PC3 repo. See plasma-frameworks for atomic commits and detailed commit messages.
-
- 05 Nov, 2022 1 commit
-
-
Script Kiddy authored
-
- 04 Nov, 2022 1 commit
-
-
Nate Graham authored
Right now there's logic to try to predict how long a user will need to read the tooltip, and time it out after that. This is unreliable and requires making an assumption about the user's reading speed, which is unknowable. As a result, the tooltip can still time out while you're in the middle of reading it, which is annoying. There's no real reason why we need to time it out automatically at all, so let's just keep it open while the user is still hovering the control. They're probably doing so for a good reason.
-