GitLab

Rather than switching to "button" elementType. This makes tool buttons
behave the same way regardless of whether they are flat or not. Most
importantly, this means that non-flat tool buttons now respect the
"display" property.

Also includes a small test file to compare the two.

Otherwise the size will be larger than intended.

The style can already render it, we just have no real API for it. This
change allows rendering it by setting properties["menu"] to true.

Replaced vague dots with expected surrounding context;
Reworded introduction slightly;
Added links to Qt docs.

Since Kirigami's Separator now only specifies implicitHeight, the
separator used in the background will be resized by Control. If we
specify an explicit height, it will correctly centre again.

BUG: 423653

Otherwise we can only select text with keyboard, which is unexpected.

BUG: 423236

Attached scrollbar is positioned inside the ListView, use a ScrollView instead

The implicitWidth was using the horizontal implicitWidth for vertical
sliders, which is way too wide.
The binding loops was fixed just by specifying an id for the implicitWidth value used for contentWidth.

The number of places where we want to have editable spinboxes far
exceeds the number of places where we want non-editable spinboxes. So
make the default editable, it can always be overridden by users of
SpinBox.

This also makes it behave similar to the widgets spinbox, that
apparently does not even have a non-editable mode.

Radio/check buttons really should only be on when the actual control is
in checked state.

BUG: 421695

Test Plan: {F8273961} {F8273893}

Reviewers: #kirigami, mart

Reviewed By: #kirigami, mart

Subscribers: filipf, ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D29307

Summary:
Whenever qqc release a new version the version need to be updated.
Otherwise the feature is not available to user. This change tries
to use real qml code to detect the version by creating object until
success, force to use a minimal qpa platform when running it.

Test Plan:
Run the cmake under a env without display server and version is detected
correctly.

Reviewers: #plasma, rizzitello, davidedmundson, apol, mart

Reviewed By: #plasma, davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D28859

When not using dim it breaks "click outside" for ComboBox in certain views.
It appears to be mostly scrollable KCMs due to the way we embed them.
So we keep dim on but use a transparent Item to avoid it actually dimming its surroundings.

Differential Revision: https://phabricator.kde.org/D27701

Summary:
Convert license headers to SPDX expressions and add license texts
as required by REUSE specification.

Reviewers: ngraham, davidedmundson

Reviewed By: ngraham, davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Maniphest Tasks: T11550

Differential Revision: https://phabricator.kde.org/D28382

Instead of expensive DropShadow layer.

Differential Revision: https://phabricator.kde.org/D28156

KQuickStyleItem manages its implicit size internally. Overriding it on the QML side makes it non-deterministic
which assignment wins and might cause unexpected re-evaluation of the size causing it to change.

Moreover, the CheckIndicator implicit size is based on sizeFromContents for CT_CheckBox, which in case of Breeze
(but not the Qt built-in styles) already contains some extra padding on the side between checkbox and label.
Instead of using that for layouting our full checkbox (indicator + label), do what qqc1 did and use
PM_CheckBoxLabelSpacing for spacing and PM_IndicatorWidth as size hint for the indicator.

Also while at it for radio buttons use the appropriate (PM_RadioButtonLabelSpacing and PM_ExclusiveIndicatorWidth) hints.

This makes QQC2 CheckBox and RadioButton layouted pixel-perfect to their QWidget counterparts and also fixes
it randomly changing size hints as you switch between pages as demonstrated by the bug report.

BUG: 418447

Differential Revision: https://phabricator.kde.org/D28116

Instead of expensive DropShadow layer.

Differential Revision: https://phabricator.kde.org/D28029