Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Q QQC2 Desktop Style
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1
    • Issues 1
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 9
    • Merge requests 9
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Frameworks
  • QQC2 Desktop Style
  • Merge requests
  • !136

Merged
Created Mar 18, 2022 by Gabriel Karlsson@gk🐞Contributor

Do not make space for invisible items in menus

  • Overview 1
  • Commits 1
  • Pipelines 3
  • Changes 2
  • In Menu.qml: Do not consider invisible menu items when evaluating whether to make space for icons or checkboxes.
  • In MenuSeparator.qml: Only add space for menu separators if they are visible, otherwise set the height to 0.
Before After
before after
The list view makes space for a separator and checkbox that are hidden The list view only makes space for what's visible
This is a followup to !135 (merged)
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: spacingfixes