Skip to content
  • Stefan Brüns's avatar
    [UDisks2] Use MediaRemovable to determine if media can be ejected · 6d260195
    Stefan Brüns authored
    Summary:
    The Ejectable property is mostly useless for card readers and thumb drives.
    It directly exposes a flag from the kernel, e.g. /sys/block/sdX/removable,
    which is the "removable bit" value from the SCSI INQUIRY response.
    
    Unfortunately, most vendors get this wrong, i.e. many thumb drives have
    the removable bit set, while some card readers have it cleared.
    
    The MediaRemovable bit defaults to the same value, but can be overridden
    by setting the ID_DRIVE_THUMB respectively ID_DRIVE_FLASH_{SD,CF,MS}
    properties. UDisks ships a rules file with a large number of devices
    already.
    
    Bug: 402096
    
    Test Plan:
    Thumb drive - powered down
    Card reader - ejected, stays powered
    External hard driver - powered down
    
    Reviewers: #frameworks, ngraham
    
    Reviewed By: ngraham
    
    Subscribers: kde-frameworks-devel
    
    Tags: #frameworks
    
    Differential Revision: https://phabricator.kde.org/D17910
    6d260195