1. 27 Dec, 2018 2 commits
  2. 09 Dec, 2018 1 commit
  3. 04 Dec, 2018 1 commit
  4. 01 Dec, 2018 2 commits
  5. 30 Nov, 2018 2 commits
  6. 17 Nov, 2018 1 commit
  7. 10 Nov, 2018 1 commit
  8. 06 Nov, 2018 1 commit
  9. 05 Nov, 2018 2 commits
  10. 04 Nov, 2018 1 commit
    • Nate Graham's avatar
      Use the new `drive-harddisk-root` icon for the root volume · b34d13cb
      Nate Graham authored
      Summary:
      Use the new `drive-harddisk-root` icon to mark the root volume. This makes it obvious which disk corresponds to `/` when there are multiple disks, and allows us to remove the {nav root} entry from the top section of the {nav Places} panel (D15739)
      
      Depends on D16633
      
      Test Plan:
      {F6388890}
      
      {F6388889}
      
      Reviewers: romangg, #vdg, #dolphin, #frameworks, bruns, abetts
      
      Reviewed By: #vdg, bruns, abetts
      
      Subscribers: abetts, kde-frameworks-devel
      
      Tags: #frameworks
      
      Maniphest Tasks: T8349
      
      Differential Revision: https://phabricator.kde.org/D16653
      b34d13cb
  11. 03 Nov, 2018 1 commit
  12. 25 Oct, 2018 1 commit
  13. 15 Oct, 2018 1 commit
  14. 09 Oct, 2018 1 commit
  15. 08 Oct, 2018 1 commit
    • Stefan Brüns's avatar
      [UDisks2] Power down drive on remove if supported · 867f5360
      Stefan Brüns authored
      Summary:
      It is preferable to to do a controlled shutdown prior to disconnecting
      and eventually cutting of power to the drive.
      
      BUG: 270808
      Closes T9730
      
      Test Plan:
      Connect external drive, select "Savely Remove" from context menu
      1. if drive has only on partition, fs is unmounted and drive spins down
      2. if drive has multiple partitions:
       a) first (not last) partition can be unmounted and remounted
       b) "Remove"ing last partition spins down drive
      
      Reviewers: #frameworks, ngraham, broulik
      
      Reviewed By: ngraham, broulik
      
      Subscribers: broulik, kde-frameworks-devel, ngraham
      
      Tags: #frameworks
      
      Maniphest Tasks: T9730
      
      Differential Revision: https://phabricator.kde.org/D15932
      867f5360
  16. 07 Oct, 2018 1 commit
  17. 06 Oct, 2018 1 commit
    • Nate Graham's avatar
      Don't show an emblem for mounted disks, only unmounted disks · 8c868ae8
      Nate Graham authored
      Summary:
      The HIG now states that should only be used for non-default, uncommon, unusual, or unexpected  statuses: https://hig.kde.org/components/assistance/emblem.html
      
      Accordingly, we should only show an emblem when a disk is unmounted, not when it's mounted. Being mounted is the expected status for a disk; being unmounted-but-visible-anyway is what's unusual and deserves an emblem.
      
      As an added bonus, this hugely improves the look of the {nav Places} panel by default.
      
      Closes T9740
      
      Test Plan:
      Dolphin {nav Places} panel now:
      {F6302248, size=full}
      
      Devices Notifier:
      {F6303952, size=full}
      
      Reviewers: #vdg, abetts
      
      Reviewed By: #vdg, abetts
      
      Subscribers: broulik, kde-frameworks-devel
      
      Tags: #frameworks
      
      Maniphest Tasks: T9740
      
      Differential Revision: https://phabricator.kde.org/D15935
      8c868ae8
  18. 28 Sep, 2018 2 commits
  19. 27 Sep, 2018 3 commits
  20. 17 Sep, 2018 3 commits
  21. 13 Sep, 2018 1 commit
  22. 12 Sep, 2018 2 commits
  23. 08 Sep, 2018 1 commit
  24. 06 Sep, 2018 1 commit
  25. 05 Sep, 2018 1 commit
  26. 31 Aug, 2018 1 commit
  27. 26 Aug, 2018 1 commit
    • Stefan Brüns's avatar
      solid/udisks2: Add support for categorized logging · 8b921f53
      Stefan Brüns authored
      Summary:
      Allow users to enable/disable messages from the UDisks2 backend to aid
      debugging issues seen only in specific configurations.
      
      Debug levels of individual messages is unchanged, these likely needs
      some further refinement.
      
      Test Plan:
      Run:
      ./bin/solid-hardware5 listen
      QT_LOGGING_RULES="org.kde.solid.*.debug=false" ./bin/solid-hardware5 listen
      QT_LOGGING_RULES="org.kde.solid.*.debug=true" ./bin/solid-hardware5 listen
      Plug/unplug USB storage device
      
      -> first two invocations show same output as before
      -> third invocation shows additional output, added/lost interfaces
      
      Reviewers: #frameworks, broulik
      
      Reviewed By: broulik
      
      Subscribers: broulik, kde-frameworks-devel
      
      Tags: #frameworks
      
      Differential Revision: https://phabricator.kde.org/D15090
      8b921f53
  28. 23 Aug, 2018 1 commit
  29. 14 Aug, 2018 1 commit
    • Stefan Brüns's avatar
      Force reevaluation of Predicates if interfaces are removed · 8e9fc899
      Stefan Brüns authored
      Summary:
      If an application wants to show only specicific devices based on predicate
      matching, and one of the matching devices loses an interface which is
      critical for the Predicate to match, the application has to be notified.
      
      As there is no dedicated signal to notify the application about the
      fact a device no longer has e.g. a Solid::StorageAccess iface, signal the
      device has been removed, and immediately readd it, as the device may
      still be relevant.
      
      Remove the call to updateBackend(udi), as the device backend listens to
      the InterfacesRemoved signal itself and updates its property cache.
      
      CCBUG: 394348
      
      Test Plan:
      1. Image file mounting via loop-back
        - udisksctl loop-setup -f ~/fat.img
        -> Icon appears under "Devices"
        - unmount via context-menu in dolphin
        -> device icon stays in "Devices"
        - set "Auto-clear" flag on loop (e.g. losetup --detach-all)
        - remount
        - unmount
        -> device icon vanishes from "Devices"
      2. CD-ROM/DVD
        -  icon appear when a non-blank medium is inserted
        - vanishes on medium removal
      3. USB stick
        - for each mountable filesystem, an icon appears under "Removable devices"
        - formatting a partition with a non-mountable filesystem/blank removes the entry
        - formatting with a mountable FS (re)adds the entry
      
      Reviewers: #frameworks, broulik, ngraham, apol
      
      Reviewed By: broulik
      
      Subscribers: apol, anthonyfieroni, kde-frameworks-devel
      
      Tags: #frameworks
      
      Differential Revision: https://phabricator.kde.org/D14661
      8e9fc899
  30. 11 Aug, 2018 1 commit