GitLab

They are not used.

There's currently no generic Bluetooth device type in UPower, so we get them of "unknown" type.
Check for whether it comes from Bluez to determine it's a Bluetooth battery.

Differential Revision: https://phabricator.kde.org/D17345

Summary:
I committed D16653 too soon without enough testing, because it had the effect of applying the default `drive-harddisk` icon to more device types. Oops. Sorry about that. :(

This patch fixes the problem, and is better tested.

Test Plan:
Other device types are not affected:
{F6392616}

Reviewers: bruns, broulik, davidedmundson

Reviewed By: broulik

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D16678

Summary:
Use the new `drive-harddisk-root` icon to mark the root volume. This makes it obvious which disk corresponds to `/` when there are multiple disks, and allows us to remove the {nav root} entry from the top section of the {nav Places} panel (D15739)

Depends on D16633

Test Plan:
{F6388890}

{F6388889}

Reviewers: romangg, #vdg, #dolphin, #frameworks, bruns, abetts

Reviewed By: #vdg, bruns, abetts

Subscribers: abetts, kde-frameworks-devel

Tags: #frameworks

Maniphest Tasks: T8349

Differential Revision: https://phabricator.kde.org/D16653

Differential Revision: https://phabricator.kde.org/D16427

Summary:
It is preferable to to do a controlled shutdown prior to disconnecting
and eventually cutting of power to the drive.

BUG: 270808
Closes T9730

Test Plan:
Connect external drive, select "Savely Remove" from context menu
1. if drive has only on partition, fs is unmounted and drive spins down
2. if drive has multiple partitions:
 a) first (not last) partition can be unmounted and remounted
 b) "Remove"ing last partition spins down drive

Reviewers: #frameworks, ngraham, broulik

Reviewed By: ngraham, broulik

Subscribers: broulik, kde-frameworks-devel, ngraham

Tags: #frameworks

Maniphest Tasks: T9730

Differential Revision: https://phabricator.kde.org/D15932

Summary:
The HIG now states that should only be used for non-default, uncommon, unusual, or unexpected  statuses: https://hig.kde.org/components/assistance/emblem.html

Accordingly, we should only show an emblem when a disk is unmounted, not when it's mounted. Being mounted is the expected status for a disk; being unmounted-but-visible-anyway is what's unusual and deserves an emblem.

As an added bonus, this hugely improves the look of the {nav Places} panel by default.

Closes T9740

Test Plan:
Dolphin {nav Places} panel now:
{F6302248, size=full}

Devices Notifier:
{F6303952, size=full}

Reviewers: #vdg, abetts

Reviewed By: #vdg, abetts

Subscribers: broulik, kde-frameworks-devel

Tags: #frameworks

Maniphest Tasks: T9740

Differential Revision: https://phabricator.kde.org/D15935

Test Plan: make

Reviewers: #frameworks, broulik

Reviewed By: broulik

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D15806

Test Plan: make

Reviewers: #frameworks, broulik

Reviewed By: broulik

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D15805

Test Plan:
install solid.categories into config directory
start kdebugsettings

Reviewers: #frameworks, broulik

Reviewed By: broulik

Subscribers: broulik, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D15800

Summary: Add infrastructure to use categorized logging in the fstab backend

Test Plan: make

Reviewers: #frameworks, broulik

Reviewed By: broulik

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D15799

Summary:
The leading slash is stripped to save some space for the human readable
description ("share on server"). In case of an exported root filesystem,
this creates an empty export name, so readd the slash.

BUG: 395562

Test Plan:
Create two entries in fstab:
`server:/  /mnt/a/ nfs defaults 0 0`
`server:/b /mnt/b/ nfs defaults 0 0`
run e.g. solid-hardware5 list details
result
` description = '/ on server'`
` description = 'b on server'`

Reviewers: #frameworks, broulik

Reviewed By: broulik

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D15798

Seen by clazy range-loop

Seen by clazy qstring-arg

Only if not present will it fall back to the file name

Summary:
Allow users to enable/disable messages from the UDisks2 backend to aid
debugging issues seen only in specific configurations.

Debug levels of individual messages is unchanged, these likely needs
some further refinement.

Test Plan:
Run:
./bin/solid-hardware5 listen
QT_LOGGING_RULES="org.kde.solid.*.debug=false" ./bin/solid-hardware5 listen
QT_LOGGING_RULES="org.kde.solid.*.debug=true" ./bin/solid-hardware5 listen
Plug/unplug USB storage device

-> first two invocations show same output as before
-> third invocation shows additional output, added/lost interfaces

Reviewers: #frameworks, broulik

Reviewed By: broulik

Subscribers: broulik, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D15090

Avoids showing C: () for drives without a label

Differential Revision: https://phabricator.kde.org/D14994

Summary:
If an application wants to show only specicific devices based on predicate
matching, and one of the matching devices loses an interface which is
critical for the Predicate to match, the application has to be notified.

As there is no dedicated signal to notify the application about the
fact a device no longer has e.g. a Solid::StorageAccess iface, signal the
device has been removed, and immediately readd it, as the device may
still be relevant.

Remove the call to updateBackend(udi), as the device backend listens to
the InterfacesRemoved signal itself and updates its property cache.

CCBUG: 394348

Test Plan:
1. Image file mounting via loop-back
  - udisksctl loop-setup -f ~/fat.img
  -> Icon appears under "Devices"
  - unmount via context-menu in dolphin
  -> device icon stays in "Devices"
  - set "Auto-clear" flag on loop (e.g. losetup --detach-all)
  - remount
  - unmount
  -> device icon vanishes from "Devices"
2. CD-ROM/DVD
  -  icon appear when a non-blank medium is inserted
  - vanishes on medium removal
3. USB stick
  - for each mountable filesystem, an icon appears under "Removable devices"
  - formatting a partition with a non-mountable filesystem/blank removes the entry
  - formatting with a mountable FS (re)adds the entry

Reviewers: #frameworks, broulik, ngraham, apol

Reviewed By: broulik

Subscribers: apol, anthonyfieroni, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D14661