1. 07 Dec, 2019 2 commits
  2. 12 Nov, 2019 1 commit
    • Rok Mandeljc's avatar
      [udisks2] fix media change detection for external optical drives · 4aa39aed
      Rok Mandeljc authored
      Summary:
      If an external optical drive is connected after Solid does its initial introspection, the resulting UDI does not get a mediaChanged signal/slot connection, and thus fails to react to the media change. Consequently, disc content is not properly updated after the medium is ejected, causing bug #394348.
      
      This patch assumes that an addition of "org.freedesktop.UDisks2.Block" interface means that a new device has been added; in this case, it performs Device::mightBeOpticalDisc() check to add the slotMediaChanged() connection.
      
      BUG: 394348
      FIXED-IN: 5.65
      
      Test Plan:
      Test steps:
      1. Start KDE Plasma session. Make sure K3b is installed.
      2. Connect an external USB optical drive.
      3. Insert the disc
      4. Observe Device action notifications for the inserted disc.
      5. Eject the disc.
      6. Observe Device action notifications.
      
      Behavior before patch: after disc is ejected, a "Copy with K3b" action remains available for the drive
      See: https://bugs.kde.org/show_bug.cgi?id=394348
      
      Behavior after patch: after disc is ejected, no actions remain available for the drive
      
      Reviewers: bruns, broulik, dfaure, #frameworks, ngraham
      
      Reviewed By: ngraham
      
      Subscribers: ngraham, bugseforuns, kde-frameworks-devel
      
      Tags: #frameworks
      
      Differential Revision: https://phabricator.kde.org/D20508
      4aa39aed
  3. 10 Nov, 2019 1 commit
  4. 03 Nov, 2019 1 commit
  5. 02 Nov, 2019 1 commit
  6. 24 Oct, 2019 1 commit
  7. 22 Oct, 2019 1 commit
  8. 20 Oct, 2019 1 commit
  9. 15 Oct, 2019 1 commit
    • Friedrich W. H. Kossebau's avatar
      Use ECMGenerateExportHeader to manage deprecated API better · 280911f7
      Friedrich W. H. Kossebau authored
      Summary:
      Allows
      * projects linking to Solid to hide deprecated API up to a
        given version or silence deprecation warnings after a given version,
        using
        * -DSOLID_DISABLE_DEPRECATED_BEFORE_AND_AT
        * -DSOLID_NO_DEPRECATED
        * -DSOLID_DEPRECATED_WARNINGS_SINCE
        * -DSOLID_NO_DEPRECATED_WARNINGS
      
        or
        * -DKF_DISABLE_DEPRECATED_BEFORE_AND_AT
        * -DKF_NO_DEPRECATED
        * -DKF_DEPRECATED_WARNINGS_SINCE
        * -DKF_NO_DEPRECATED_WARNINGS
      * to build Solid optionally with deprecated API excluded from
        the build, using "EXCLUDE_DEPRECATED_BEFORE_AND_AT" cmake argument.
      
      Test Plan:
      Builds with EXCLUDE_DEPRECATED_BEFORE_AND_AT set to 0, 5.0.0, CURRENT.
      280911f7
  10. 12 Oct, 2019 1 commit
  11. 11 Oct, 2019 1 commit
  12. 06 Oct, 2019 1 commit
  13. 03 Oct, 2019 1 commit
  14. 17 Sep, 2019 1 commit
  15. 16 Sep, 2019 1 commit
  16. 14 Sep, 2019 1 commit
  17. 13 Sep, 2019 1 commit
  18. 09 Sep, 2019 1 commit
  19. 08 Sep, 2019 2 commits
  20. 07 Sep, 2019 1 commit
  21. 31 Aug, 2019 1 commit
  22. 20 Aug, 2019 1 commit
  23. 15 Aug, 2019 1 commit
  24. 11 Aug, 2019 1 commit
  25. 09 Aug, 2019 1 commit
    • Luca Beltrame's avatar
      Fix build · cd306b21
      Luca Beltrame authored
      Apparently QDBusVariant include is required.
      cd306b21
  26. 08 Aug, 2019 1 commit
  27. 03 Aug, 2019 1 commit
  28. 02 Aug, 2019 1 commit
  29. 13 Jul, 2019 2 commits
    • Script Kiddy's avatar
      GIT_SILENT Upgrade KF5 version to 5.61.0. · 5e194c47
      Script Kiddy authored
      5e194c47
    • Aleix Pol Gonzalez's avatar
      Make sure solid backends are reentrant · 00abb483
      Aleix Pol Gonzalez authored
      Summary:
      Solid will create different backends for each separate thread but then some backends will use singletons to share some information.
      This patch includes measures so this sharing only happens within the same thread or adds the necessary locks so threads respect each other.
      
      Test Plan: Tests pass, logic makes sense to me, plasmashell doesn't crash when using D22333 (not that it fixes any crashes there)
      
      Reviewers: #frameworks, davidedmundson, bruns
      
      Reviewed By: davidedmundson
      
      Subscribers: bruns, kde-frameworks-devel
      
      Tags: #frameworks
      
      Differential Revision: https://phabricator.kde.org/D22339
      00abb483
  30. 06 Jul, 2019 1 commit
  31. 04 Jul, 2019 1 commit
  32. 25 Jun, 2019 2 commits
    • Stefan Brüns's avatar
      [Fstab] Select appropriate icon for home or root directory · 541a3d3a
      Stefan Brüns authored
      Summary: Depends on D22080
      
      Reviewers: ngraham, fvogt, broulik
      
      Reviewed By: ngraham, fvogt, broulik
      
      Subscribers: kde-frameworks-devel
      
      Tags: #frameworks
      
      Differential Revision: https://phabricator.kde.org/D22081
      541a3d3a
    • Stefan Brüns's avatar
      [Fstab] Show mounted "overlay" filesystems · 54a501f0
      Stefan Brüns authored
      Summary:
      Overlay filesystems are not enumerated by udisks, so add support for these
      to the fstab backend
      
      See also D15739
      
      Test Plan:
      $> grep overlay /proc/self/mounts
      
      NAME /mnt overlay rw,relatime,lowerdir=/home/stefan/tmp/,upperdir=/tmp/overlay/rw,workdir=/tmp/overlay/work 0 0
      NAME /home/stefan/tmp2 overlay rw,relatime,lowerdir=/home/stefan/tmp/,upperdir=/tmp/overlay2/rw,workdir=/tmp/overlay2/work 0 0
      
      $> solid-hardware5 list details
      ...
      udi = '/org/kde/fstab/overlay/mnt'
        parent = '/org/kde/fstab'  (string)
        vendor = 'overlay'  (string)
        product = '/mnt'  (string)
        description = '/mnt (overlay)'  (string)
        icon = 'folder'  (string)
        StorageAccess.accessible = true  (bool)
        StorageAccess.filePath = '/mnt'  (string)
        StorageAccess.ignored = false  (bool)
      
      udi = '/org/kde/fstab/overlay/home/stefan/tmp2'
        parent = '/org/kde/fstab'  (string)
        vendor = 'overlay'  (string)
        product = '~/tmp2'  (string)
        description = '~/tmp2 (overlay)'  (string)
        icon = 'folder'  (string)
        StorageAccess.accessible = true  (bool)
        StorageAccess.filePath = '/home/stefan/tmp2'  (string)
        StorageAccess.ignored = false  (bool)
      
      Reviewers: ngraham, fvogt, broulik
      
      Reviewed By: ngraham, fvogt, broulik
      
      Subscribers: kde-frameworks-devel
      
      Tags: #frameworks
      
      Differential Revision: https://phabricator.kde.org/D22080
      54a501f0
  33. 12 Jun, 2019 1 commit
  34. 08 Jun, 2019 1 commit
  35. 06 Jun, 2019 1 commit
  36. 01 Jun, 2019 1 commit