1. 18 Jan, 2022 1 commit
  2. 15 Jan, 2022 1 commit
  3. 08 Jan, 2022 1 commit
  4. 06 Jan, 2022 1 commit
  5. 03 Jan, 2022 2 commits
  6. 01 Jan, 2022 1 commit
  7. 24 Dec, 2021 1 commit
  8. 22 Dec, 2021 1 commit
  9. 20 Dec, 2021 2 commits
    • Ahmad Samir's avatar
      Remove trailing \x00 from string returned by Q6File::decodeName() · 85524ca1
      Ahmad Samir authored
      \x00 in hexadecimal, or \0 in octal (reminding myself).
      
      In Qt5:
      QFile::decodeName(QByteArray &ba) calls:
      static inline QString fromLocal8Bit(const QByteArray &str)
      { return str.isNull() ? QString() : fromLocal8Bit(str.data(), qstrnlen(str.constData(), str.size())); }
      
      qstrnlen() returns the length excluding the terminating \0.
      
      In Qt6:
      QFile::decodeName(QByteArray &ba) calls:
      static inline QString fromLocal8Bit(const QByteArray &ba) { return fromLocal8Bit(QByteArrayView(ba)); }
      which uses this constructor:
      QByteArrayView(const ByteArray &ba) noexcept
              : QByteArrayView(ba.isNull() ? nullptr : ba.data(), qsizetype(ba.size())) {}
      
      ba.size() will include the terminating \0 if the QByteArray was created
      with the constructor that takes a size (the BA is gotten from UDisks backend
      so not surprisingly it's created from a char* with a terminating \0).
      
      QString::fromLocal8Bit(QByteArrayView ba) will return any \0 characters
      converted to unicode null \u0000, but won't remove them.
      
      So, with Qt6, we need to chop the terminating \0 character (as is already
      done in baseMountPoint() in the same .cpp file).
      85524ca1
    • Ahmad Samir's avatar
      Change the build system to enable building with Qt6 · 57e7b5a7
      Ahmad Samir authored
      This was built with:
      -DQT_MAJOR_VERSION=6 \
      -DEXCLUDE_DEPRECATED_BEFORE_AND_AT=5.90.0 \
      -DKF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x055a00
      
      solidhwtest is failing with:
      FAIL!  : SolidHwTest::testPredicate() 'p6.matches(dev)' returned FALSE. ()
          Loc: [/home/ahmad/dev6/solid/autotests/solidhwtest.cpp(336)]
      
      An issue caused by upstream changes to how QVariant::operator== works in Qt6.
      57e7b5a7
  10. 17 Dec, 2021 1 commit
  11. 13 Dec, 2021 1 commit
  12. 04 Dec, 2021 1 commit
  13. 02 Dec, 2021 1 commit
  14. 23 Nov, 2021 1 commit
  15. 19 Nov, 2021 1 commit
  16. 18 Nov, 2021 1 commit
  17. 13 Nov, 2021 1 commit
  18. 09 Nov, 2021 3 commits
  19. 05 Nov, 2021 1 commit
  20. 03 Nov, 2021 2 commits
  21. 01 Nov, 2021 1 commit
  22. 29 Oct, 2021 1 commit
  23. 26 Oct, 2021 1 commit
  24. 09 Oct, 2021 1 commit
  25. 06 Oct, 2021 2 commits
  26. 03 Oct, 2021 1 commit
  27. 02 Oct, 2021 1 commit
  28. 29 Sep, 2021 1 commit
  29. 20 Sep, 2021 1 commit
  30. 11 Sep, 2021 1 commit
  31. 05 Sep, 2021 3 commits
  32. 04 Sep, 2021 1 commit