GitLab

ivan tkachenko authored Jan 17, 2022 and Nate Graham committed Jan 18, 2022

The same rounding is already used for charge percent just few lines
above. Without it, for example, values that are close to 100%
(e.g. 99.9825%) were rounded down to 99% instead of up to 100%.

BUG: 448372
FIXED-IN: 5.91

Instead of /usr/include/KF5/solid_version.h.

For more details see:
kservice!79

GIT_SILENT

Instead of only doing it explicitly for `UP_DEVICE_KIND_UNKNOWN`
we'll check it for any battery that we did not handle, so that
we at least know it's a Bluetooth battery should UPower gain
additional device types in the future, as has happened before.

Snaps set this attribute.

See: kxmlgui!88

NO_CHANGELOG

\x00 in hexadecimal, or \0 in octal (reminding myself).

In Qt5:
QFile::decodeName(QByteArray &ba) calls:
static inline QString fromLocal8Bit(const QByteArray &str)
{ return str.isNull() ? QString() : fromLocal8Bit(str.data(), qstrnlen(str.constData(), str.size())); }

qstrnlen() returns the length excluding the terminating \0.

In Qt6:
QFile::decodeName(QByteArray &ba) calls:
static inline QString fromLocal8Bit(const QByteArray &ba) { return fromLocal8Bit(QByteArrayView(ba)); }
which uses this constructor:
QByteArrayView(const ByteArray &ba) noexcept
        : QByteArrayView(ba.isNull() ? nullptr : ba.data(), qsizetype(ba.size())) {}

ba.size() will include the terminating \0 if the QByteArray was created
with the constructor that takes a size (the BA is gotten from UDisks backend
so not surprisingly it's created from a char* with a terminating \0).

QString::fromLocal8Bit(QByteArrayView ba) will return any \0 characters
converted to unicode null \u0000, but won't remove them.

So, with Qt6, we need to chop the terminating \0 character (as is already
done in baseMountPoint() in the same .cpp file).

This was built with:
-DQT_MAJOR_VERSION=6 \
-DEXCLUDE_DEPRECATED_BEFORE_AND_AT=5.90.0 \
-DKF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x055a00

solidhwtest is failing with:
FAIL!  : SolidHwTest::testPredicate() 'p6.matches(dev)' returned FALSE. ()
    Loc: [/home/ahmad/dev6/solid/autotests/solidhwtest.cpp(336)]

An issue caused by upstream changes to how QVariant::operator== works in Qt6.

Martin Tobias Holmedahl Sandsmark authored Sep 23, 2020 and Martin Tobias Holmedahl Sandsmark committed Nov 23, 2021

udisks2 and upower are kind of shaky and noisy if enabled but masked.

"0B Removable Media" is not very helpful, just omit the size then.

This reverts commit d7f6330e.

6cac0dcc added support for pen devices
in an additional needed way, so the original work now functions as
expected and can be un-reverted.

BUG: 445141

Based on https://gitlab.freedesktop.org/upower/upower/-/commit/e294444496e8bbcd91a3605874f59562e14c34ec

This reverts commit 8789dd63.

This commit can cause wacom touchscreens built into 2-in-1 laptops to
appear as separate batteries, which isn't accurate.

Sönke Holz authored Oct 29, 2021 and Nate Graham committed Oct 29, 2021

Add a new battery type 'TabletBattery' for batteries in graphics tablets
and pens.

In ARM, /proc/cpuinfo does not contain strings, it only
contains IDs. We need to convert them into vendor/model
human-readable strings manually.

Inspiration was taken from util-linux's lscpu utility.
Signed-off-by: Alexey Minnekhanov <alexeymin@postmarketos.org>

Georgy Yakovlev authored Jul 12, 2021 and Nicolas Fella committed Sep 05, 2021

can be obtained from cpu : line

processor       : 0
cpu             : POWER9, altivec supported
clock           : 2166.000000MHz
revision        : 2.3 (pvr 004e 1203)
Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>