1. 02 Feb, 2020 1 commit
  2. 01 Feb, 2020 1 commit
  3. 30 Jan, 2020 1 commit
  4. 19 Jan, 2020 1 commit
  5. 11 Jan, 2020 1 commit
  6. 10 Jan, 2020 1 commit
  7. 06 Jan, 2020 1 commit
  8. 03 Jan, 2020 1 commit
  9. 30 Dec, 2019 1 commit
  10. 21 Dec, 2019 2 commits
  11. 19 Dec, 2019 2 commits
  12. 16 Dec, 2019 1 commit
  13. 15 Dec, 2019 4 commits
    • Aleix Pol Gonzalez's avatar
      Remove unused header from QtWidgets · e2d53825
      Aleix Pol Gonzalez authored
      e2d53825
    • Aleix Pol Gonzalez's avatar
      Fix build on BSD · 289ffb0e
      Aleix Pol Gonzalez authored
      289ffb0e
    • Martin Flöser's avatar
      Port solid from Qt5::Widgets to Qt5::Gui · 9f868681
      Martin Flöser authored
      Summary:
      The only usage of widgets was to get the active window. Incorrectly this
      was done through QWidget which would fail for any application using just
      QtGui (e.g. QtQuick).
      
      As QGuiApplication also provides access to the focus window we can use
      QtGui API instead. As a note: the whole thing is X11 specific as a
      window ID is passed to another process, which cannot work on Wayland.
      It's possible to get it work on Wayland, but that would require:
       * changes to the dbus protocol
       * add a dependency to KWayland
       * or extend QtWayland to generate the required code
      
      Test Plan: Compiles
      
      Reviewers: #frameworks, dhaumann, apol, broulik
      
      Reviewed By: dhaumann, apol, broulik
      
      Subscribers: davidedmundson, dhaumann, kde-frameworks-devel
      
      Tags: #frameworks
      
      Differential Revision: https://phabricator.kde.org/D13541
      9f868681
    • Méven Car's avatar
      Ensure mounted nfs filesystems matches their fstab declared counterpart · c97f0b2a
      Méven Car authored
      Summary:
      When a nfs fs is declared in /etc/fstab and the filesystem path ends with a / (like 192.168.1.16:/home/meven/ ), once mounted the detected filesystem path does not have the slash.
      This causes the mounted drive not to match the umounted filesystem, causing the later bug.
      
      I.e :
      
      $ solid-hardware list
      [...]
      udi = '/org/kde/fstab/192.168.1.16:/home/meven/'  (fstab declared mount)
      udi = '/org/kde/fstab/192.168.1.16:/home/meven'    (mounted drive as returned by getmntent)
      
      The patch makes the logic in Solid::Backends::Fstab::FstabHandling::deviceList matching mounted and unmounted filesytems unsensitive to their path ending with /
      
      BUG: 406242
      CCBUG: 390691
      FIXED-IN: 5.66
      
      Test Plan:
      Locally tested with Linux with a nfs drive set up with a path ending with a slash like
      192.168.1.16:/home/meven/ /media/NFS nfs defaults,user,auto,noatime,bg 0 0
      
      After patch
      $ solid-hardware list
      [...]
      udi = '/org/kde/fstab/192.168.1.16:/home/meven'    (mounted drive as returned by getmntent)
      
      Only one icon appears for the drive in places panel in Dolphin.
      
      Not tested with getmntinfo / BSD code path, but the patch does not alter the code behavior much and don't foresee any risk there.
      
      Reviewers: bruns, #frameworks, ngraham
      
      Reviewed By: bruns, ngraham
      
      Subscribers: broulik, dhaumann, anthonyfieroni, ngraham, bruns, apol, kde-frameworks-devel
      
      Tags: #frameworks
      
      Differential Revision: https://phabricator.kde.org/D21204
      c97f0b2a
  14. 14 Dec, 2019 1 commit
  15. 09 Dec, 2019 1 commit
  16. 07 Dec, 2019 1 commit
  17. 12 Nov, 2019 1 commit
    • Rok Mandeljc's avatar
      [udisks2] fix media change detection for external optical drives · 4aa39aed
      Rok Mandeljc authored
      Summary:
      If an external optical drive is connected after Solid does its initial introspection, the resulting UDI does not get a mediaChanged signal/slot connection, and thus fails to react to the media change. Consequently, disc content is not properly updated after the medium is ejected, causing bug #394348.
      
      This patch assumes that an addition of "org.freedesktop.UDisks2.Block" interface means that a new device has been added; in this case, it performs Device::mightBeOpticalDisc() check to add the slotMediaChanged() connection.
      
      BUG: 394348
      FIXED-IN: 5.65
      
      Test Plan:
      Test steps:
      1. Start KDE Plasma session. Make sure K3b is installed.
      2. Connect an external USB optical drive.
      3. Insert the disc
      4. Observe Device action notifications for the inserted disc.
      5. Eject the disc.
      6. Observe Device action notifications.
      
      Behavior before patch: after disc is ejected, a "Copy with K3b" action remains available for the drive
      See: https://bugs.kde.org/show_bug.cgi?id=394348
      
      Behavior after patch: after disc is ejected, no actions remain available for the drive
      
      Reviewers: bruns, broulik, dfaure, #frameworks, ngraham
      
      Reviewed By: ngraham
      
      Subscribers: ngraham, bugseforuns, kde-frameworks-devel
      
      Tags: #frameworks
      
      Differential Revision: https://phabricator.kde.org/D20508
      4aa39aed
  18. 10 Nov, 2019 1 commit
  19. 03 Nov, 2019 1 commit
  20. 02 Nov, 2019 1 commit
  21. 24 Oct, 2019 1 commit
  22. 22 Oct, 2019 1 commit
  23. 20 Oct, 2019 1 commit
  24. 15 Oct, 2019 1 commit
    • Friedrich W. H. Kossebau's avatar
      Use ECMGenerateExportHeader to manage deprecated API better · 280911f7
      Friedrich W. H. Kossebau authored
      Summary:
      Allows
      * projects linking to Solid to hide deprecated API up to a
        given version or silence deprecation warnings after a given version,
        using
        * -DSOLID_DISABLE_DEPRECATED_BEFORE_AND_AT
        * -DSOLID_NO_DEPRECATED
        * -DSOLID_DEPRECATED_WARNINGS_SINCE
        * -DSOLID_NO_DEPRECATED_WARNINGS
      
        or
        * -DKF_DISABLE_DEPRECATED_BEFORE_AND_AT
        * -DKF_NO_DEPRECATED
        * -DKF_DEPRECATED_WARNINGS_SINCE
        * -DKF_NO_DEPRECATED_WARNINGS
      * to build Solid optionally with deprecated API excluded from
        the build, using "EXCLUDE_DEPRECATED_BEFORE_AND_AT" cmake argument.
      
      Test Plan:
      Builds with EXCLUDE_DEPRECATED_BEFORE_AND_AT set to 0, 5.0.0, CURRENT.
      280911f7
  25. 12 Oct, 2019 1 commit
  26. 11 Oct, 2019 1 commit
  27. 06 Oct, 2019 1 commit
  28. 03 Oct, 2019 1 commit
  29. 17 Sep, 2019 1 commit
  30. 16 Sep, 2019 1 commit
  31. 14 Sep, 2019 1 commit
  32. 13 Sep, 2019 1 commit
  33. 09 Sep, 2019 1 commit
  34. 08 Sep, 2019 2 commits