Skip to content

Modelines: fix indent-mode value and remove deprecated variables

jonathan poelen requested to merge jpoelen/syntax-highlighting:bug_modelines into master

There are currently documented variables on https://docs.kde.org/stable5/en/kate/katepart/config-variables.html (where's the doc for version 6?), but they don't exist:

  • replace-tabs-save: the set-replace-tabs-save command exists but doesn't work (KTextEditor bug in utils/katecmds.h). I don't even see where this option is configured?
  • icon-border: but set-icon-border exists and works
  • folding-markers: but set-folding-markers exists and works
  • bookmark-sorting

The last 3 are in a list (document/katedocument.cpp) of values propagated to the view, but this is the only reference.

The block-selection variable exists, is documented, but doesn't work. Nor is there a set-block-selection command.

The question is, do we delete or keep? If we keep it, the least we can do is fix KTextEditor.

Still on KTextEditor, I see a reference to set-wrap-cursor, but the condition leads nowhere. What is wrap-cursor anyway?

There are also set-* missing at least for the following variables:

  • folding-preview
  • show-trailing-spaces: a code for set-show-trailing-spaces exists, but it's inaccessible and the function isn't documented.

Merge request reports