1. 09 May, 2020 1 commit
  2. 04 Apr, 2020 1 commit
  3. 17 Mar, 2020 1 commit
  4. 29 Feb, 2020 1 commit
    • Yichao Yu's avatar
      Fix accidental revealing of items when the game is restarted after lost from a middle click. · 45d7ed4e
      Yichao Yu authored
      Summary:
      When a flag is misplaced, a middle click could cause the game to lost.
      Currently, if the user choose to restart the game in this case, there is a high chance
      that a few pieces around the one middle clicked are revealed right after the game restarted.
      
      The reason is that when the user restart the game in such case,
      it happens within `checkLost`/`onItemRevealed` which means that the
      game might not be the same one anymore after `onItemRevealed` returns
      and the loop handling all neighboring pieces are now operating on the now restarted game.
      
      The fix is to make sure the loop stops when the game is finished. Checking `m_gameOver` is
      unreliable and won't work in this case since the restart of the game would have reset it.
      Instead, the finished status is returned from all functions that trigger such a condition
      and the information is propagated back to the caller to terminate the loop appropriately.
      This also improved another unreliable use of `m_gameOver` that is currently harmless.
      
      Debugging was possible thanks to `rr`.
      
      Reviewers: mlaurent, yurchor, #kde_games, aacid
      
      Reviewed By: yurchor, aacid
      
      Subscribers: aacid, kde-games-devel
      
      Differential Revision: https://phabricator.kde.org/D27716
      45d7ed4e
  5. 28 Feb, 2020 1 commit
  6. 09 Jan, 2020 1 commit
  7. 08 Jan, 2020 3 commits
  8. 26 Nov, 2019 1 commit
  9. 18 Nov, 2019 1 commit
  10. 16 Nov, 2019 1 commit
  11. 15 Nov, 2019 1 commit
  12. 12 Nov, 2019 2 commits
  13. 30 Oct, 2019 1 commit
  14. 22 Oct, 2019 1 commit
  15. 21 Oct, 2019 1 commit
  16. 11 Oct, 2019 1 commit
  17. 20 Sep, 2019 1 commit
  18. 27 Jun, 2019 1 commit
  19. 31 May, 2019 1 commit
  20. 21 May, 2019 1 commit
  21. 20 May, 2019 1 commit
  22. 10 May, 2019 2 commits
    • Heiko Becker's avatar
      Drop unused kmines.notifyrc · 704e9153
      Heiko Becker authored
      Summary:
      kmines doesn't use any knotifications, it only uses an inline
      notification widget.
      
      As far as I can tell the code which did use knotifications was
      removed almost 12 years ago with
      9ab6e091 (it unnecessarily linked to
      KF5::NotifyConfig for some time after that, but that's gone now,
      too).
      
      Test Plan:
      Doesn't install kmines.notifyrc anymore, everything keeps
      working
      
      Reviewers: #kde_games
      
      Subscribers: kde-games-devel
      
      Differential Revision: https://phabricator.kde.org/D21130
      704e9153
    • Heiko Becker's avatar
      Add .arcconfig · 1622b734
      Heiko Becker authored
      1622b734
  23. 12 Mar, 2019 1 commit
  24. 20 Jan, 2019 1 commit
  25. 07 Jan, 2019 1 commit
  26. 06 Jan, 2019 2 commits
    • Laurent Montel's avatar
      Patch from Sebastian Audet · 96884eaa
      Laurent Montel authored
      KMines Reset After Game Over.
      
      At the end of the game you are prompted to restart the same or continue to a new one.
      
      You have the option of saying 'no' - besides that unless you're in a competition I don't think it should matter. Mainly I proposed the change because there are times when its impossible to do anything but guess (not even statistics) and this is a midway between a 'reveal' button and just flat out spending 4 minutes on something and failing.
      
      Differential Revision: https://phabricator.kde.org/D17860
      96884eaa
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · f1713564
      Script Kiddy authored
      In case of conflict in i18n, keep the version of the branch "ours"
      To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
      f1713564
  27. 05 Jan, 2019 1 commit
  28. 04 Jan, 2019 1 commit
  29. 24 Dec, 2018 1 commit
  30. 12 Dec, 2018 1 commit
  31. 08 Nov, 2018 1 commit
  32. 10 Oct, 2018 2 commits
  33. 24 Sep, 2018 1 commit
  34. 03 Sep, 2018 1 commit