Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • KPat KPat
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 3
    • Merge requests 3
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Games
  • KPatKPat
  • Merge requests
  • !19

BUG: 436462, Disable notification sound for New Game warning

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Daniel Fichtner requested to merge danchete/kpat:43642-remove-notification-sound-kmessagebox into master Oct 06, 2021
  • Overview 16
  • Commits 5
  • Pipelines 8
  • Changes 3

When a game is running (you need to have atleast made one play) and you hit "New Game" a KMessageBox will be created and a Notification sound will play. The KMessageBox has the option to not play a sound, this is achieved by the added nullptr.

It would be nice, if we could toggle that sound with the "Play Sounds" toggle from the Settings menu. This could be achieved by a new member variable in the "dealer class" that is set by the toggle and creating a KMessageBox with and without the nullptr, depending on that variable.

Is there a better idea/solution? I'm still new hear, so please correct me if I do something wrong :)

Edited Oct 06, 2021 by Daniel Fichtner
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: 43642-remove-notification-sound-kmessagebox